Skip to content

[SPARK-29653][SQL] Fix MICROS_PER_MONTH in IntervalUtils #26321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 3 commits into from
Closed

[SPARK-29653][SQL] Fix MICROS_PER_MONTH in IntervalUtils #26321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d20988a
[SPARK-29653][SQL] Fix MICROS_PER_MONTH in IntervalUtils
yaooqinn Oct 30, 2019
7cc8edc
fix date_part get epoch
yaooqinn Oct 30, 2019
f1f090a
rm test
yaooqinn Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ object IntervalUtils {
final val MICROS_PER_MINUTE: Long =
DateTimeUtils.MILLIS_PER_MINUTE * DateTimeUtils.MICROS_PER_MILLIS
final val DAYS_PER_MONTH: Byte = 30
final val MICROS_PER_MONTH: Long = DAYS_PER_MONTH * DateTimeUtils.SECONDS_PER_DAY
final val MICROS_PER_MONTH: Long = DAYS_PER_MONTH * DateTimeUtils.MICROS_PER_DAY
/* 365.25 days per year assumes leap year every four years */
final val MICROS_PER_YEAR: Long = (36525L * DateTimeUtils.MICROS_PER_DAY) / 100

Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/resources/sql-tests/results/date_part.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ select date_part('epoch', c) from t2
-- !query 106 schema
struct<date_part('epoch', t2.`c`):decimal(18,6)>
-- !query 106 output
31873892788.332003
31897220765.004003
Copy link
Member

@MaxGekk MaxGekk Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have compared to PostgreSQL output:

maxim=# select date_part('epoch', interval '1010 year 9 month 8 day 7 hour 6 minute 5 second 4 millisecond 3 microseconds');
    date_part
-----------------
 31897220765.004
(1 row)

It seems PostgreSQL just looses the precision.



-- !query 107
Expand Down