Skip to content

[SPARK-29637][CORE] Add description to Job SHS web API #26295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 1 commit into from
Closed

[SPARK-29637][CORE] Add description to Job SHS web API #26295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ private[spark] class AppStatusListener(

val lastStageInfo = event.stageInfos.sortBy(_.stageId).lastOption
val jobName = lastStageInfo.map(_.name).getOrElse("")
val description = Option(event.properties)
.flatMap { p => Option(p.getProperty(SparkContext.SPARK_JOB_DESCRIPTION)) }
val jobGroup = Option(event.properties)
.flatMap { p => Option(p.getProperty(SparkContext.SPARK_JOB_GROUP_ID)) }
val sqlExecutionId = Option(event.properties)
Expand All @@ -363,6 +365,7 @@ private[spark] class AppStatusListener(
val job = new LiveJob(
event.jobId,
jobName,
description,
if (event.time > 0) Some(new Date(event.time)) else None,
event.stageIds,
jobGroup,
Expand Down
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/status/LiveEntity.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ private[spark] abstract class LiveEntity {
private class LiveJob(
val jobId: Int,
name: String,
description: Option[String],
val submissionTime: Option[Date],
val stageIds: Seq[Int],
jobGroup: Option[String],
Expand Down Expand Up @@ -92,7 +93,7 @@ private class LiveJob(
val info = new v1.JobData(
jobId,
name,
None, // description is always None?
description,
submissionTime,
completionTime,
stageIds,
Expand Down
3 changes: 2 additions & 1 deletion core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class AppStatusListenerSuite extends SparkFunSuite with BeforeAndAfter {
new StageInfo(2, 0, "stage2", 4, Nil, Seq(1), "details2"))

val jobProps = new Properties()
jobProps.setProperty(SparkContext.SPARK_JOB_DESCRIPTION, "jobDescription")
jobProps.setProperty(SparkContext.SPARK_JOB_GROUP_ID, "jobGroup")
jobProps.setProperty(SparkContext.SPARK_SCHEDULER_POOL, "schedPool")

Expand All @@ -163,7 +164,7 @@ class AppStatusListenerSuite extends SparkFunSuite with BeforeAndAfter {
check[JobDataWrapper](1) { job =>
assert(job.info.jobId === 1)
assert(job.info.name === stages.last.name)
assert(job.info.description === None)
assert(job.info.description === Some("jobDescription"))
assert(job.info.status === JobExecutionStatus.RUNNING)
assert(job.info.submissionTime === Some(new Date(time)))
assert(job.info.jobGroup === Some("jobGroup"))
Expand Down