-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29612][SQL] ALTER TABLE (RECOVER PARTITIONS) should look up catalog/table like v2 commands #26269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…talog/table like v2 commands
|
Test build #112722 has finished for PR 26269 at commit
|
|
retest this please |
|
Test build #112725 has finished for PR 26269 at commit
|
|
@viirya Could you please review? The unit tests failed, but it doesn't seem to be related to my changes. |
|
retest this please |
|
The description is not correct at all, |
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
Outdated
Show resolved
Hide resolved
|
Test build #112799 has finished for PR 26269 at commit
|
|
Test build #112804 has finished for PR 26269 at commit
|
|
thanks, merging to master! |
|
Thanks! @cloud-fan @viirya |
imback82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late +1
What changes were proposed in this pull request?
Add AlterTableRecoverPartitionsStatement and make ALTER TABLE ... RECOVER PARTITIONS go through the same catalog/table resolution framework of v2 commands.
Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.
Does this PR introduce any user-facing change?
Yes. When running ALTER TABLE ... RECOVER PARTITIONS Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.
How was this patch tested?
Unit tests.