[SPARK-29008][SQL][FOLLOW-UP] Checks correct param lengths of split methods #26267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
commented
Oct 26, 2019
| val inputVarsForAllFuncs = commonExprs.map { expr => | ||
| getLocalInputVariableValues(this, expr.head).toSeq | ||
| } | ||
| if (inputVarsForAllFuncs.map(calculateParamLengthFromExprValues).forall(isValidParamLength)) { |
Member
Author
There was a problem hiding this comment.
@viirya @cloud-fan sorry, but I found my mistake made in SPARK-29008... Could you check?
Member
There was a problem hiding this comment.
yea, good catch! We should check param length for input parameters to common expressions.
|
Test build #112714 has finished for PR 26267 at commit
|
viirya
approved these changes
Oct 26, 2019
Member
Author
|
@viirya many thanks! |
dongjoon-hyun
approved these changes
Oct 28, 2019
Member
Author
|
Thanks for the merging, @dongjoon-hyun ! |
Contributor
|
late LGTM, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is to fix wrong code to check parameter lengths of split methods in
subexpressionEliminationForWholeStageCodegen.Why are the changes needed?
Bug fix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.