[SPARK-29589][WEBUI] Support pagination for sqlstats session table in JDBC/ODBC Session page #26246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahidki31
changed the title
Contributor
Author
shahidki31
commented
Oct 24, 2019
| import org.apache.commons.text.StringEscapeUtils | ||
|
|
||
| import org.apache.spark.internal.Logging | ||
| import org.apache.spark.sql.hive.thriftserver.HiveThriftServer2.{ExecutionInfo, ExecutionState, SessionInfo} |
shahidki31
commented
Oct 24, 2019
| <tr> {data.map(d => <td>{d}</td>)} </tr> | ||
| } | ||
| UIUtils.listingTable(headers, generateDataRow, data, fixedWidth = true) | ||
| } |
|
Test build #112615 has finished for PR 26246 at commit
|
srowen
reviewed
Oct 24, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Generally looking good as a cleanup
...thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
Show resolved
Hide resolved
Contributor
Author
|
Retest this please |
|
Test build #112648 has finished for PR 26246 at commit
|
|
Test build #112651 has finished for PR 26246 at commit
|
|
Test build #112667 has finished for PR 26246 at commit
|
srowen
approved these changes
Oct 25, 2019
Member
|
Merged to master |
Contributor
Author
|
Thanks @srowen |
dengziming
pushed a commit
to dengziming/spark
that referenced
this pull request
Oct 28, 2019
… JDBC/ODBC Session page In the PR apache#26215, we supported pagination for sqlstats table in JDBC/ODBC server page. In this PR, we are extending the support of pagination to sqlstats session table by making use of existing pagination classes in apache#26215. Support pagination for sqlsessionstats table in JDBC/ODBC server page in the WEBUI. It will easier for user to analyse the table and it may fix the potential issues like oom while loading the page, that may occur similar to the SQL page (refer apache#22645) There will be no change in the sqlsessionstats table in JDBC/ODBC server page execpt pagination support. Manually verified. Before:  After:  Closes apache#26246 from shahidki31/SPARK_29589. Authored-by: shahid <[email protected]> Signed-off-by: Sean Owen <[email protected]> Signed-off-by: dengziming <[email protected]>
| <td>{formatDate(info.startTimestamp)}</td> | ||
| <td>{if (info.finishTimestamp > 0) formatDate(info.finishTimestamp)}</td> | ||
| <td>{if (info.closeTimestamp > 0) formatDate(info.closeTimestamp)}</td> | ||
| <td sorttable_customkey={info.totalTime(info.finishTimestamp).toString}> |
Contributor
There was a problem hiding this comment.
did we remove this sorting option from the new table?
Contributor
Author
There was a problem hiding this comment.
Yes, because this is no longer required as we are sorting on the raw data.
I verified, and sorting is working properly for all the columns. Did you face any issues?
Contributor
There was a problem hiding this comment.
Thanks for the explanation @shahidki31 !
Indeed it works, sorry for my confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR #26215, we supported pagination for sqlstats table in JDBC/ODBC server page. In this PR, we are extending the support of pagination to sqlstats session table by making use of existing pagination classes in #26215.
Why are the changes needed?
Support pagination for sqlsessionstats table in JDBC/ODBC server page in the WEBUI. It will easier for user to analyse the table and it may fix the potential issues like oom while loading the page, that may occur similar to the SQL page (refer #22645)
Does this PR introduce any user-facing change?
There will be no change in the sqlsessionstats table in JDBC/ODBC server page execpt pagination support.
How was this patch tested?
Manually verified.
Before:
After: