Skip to content

[SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands #26184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 7 commits into from
Closed

[SPARK-29527][SQL] SHOW CREATE TABLE should look up catalog/table like v2 commands #26184

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3687933
SHOW CREATE TABLE should do multi-catalog resolution.
viirya Oct 20, 2019
6edf9d7
Merge remote-tracking branch 'upstream/master' into SPARK-29527
viirya Oct 23, 2019
d1f914e
Resolve merging conflict.
viirya Oct 23, 2019
8f33e02
Address comment.
viirya Oct 23, 2019
80b80e5
For review comment.
viirya Oct 24, 2019
cd8fb2c
Merge remote-tracking branch 'upstream/master' into SPARK-29527
viirya Oct 24, 2019
6cb88c9
Merge remote-tracking branch 'upstream/master' into SPARK-29527
viirya Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1268,23 +1268,19 @@ class DataSourceV2SQLSuite
}
}

private def testV1Command(sqlCommand: String, sqlParams: String): Unit = {
val e = intercept[AnalysisException] {
sql(s"$sqlCommand $sqlParams")
}
assert(e.message.contains(s"$sqlCommand is only supported with v1 tables"))
}

test("SHOW CREATE TABLE") {
val t = "testcat.ns1.ns2.tbl"
withTable(t) {
spark.sql(s"CREATE TABLE $t (id bigint, data string) USING foo")
testV1Command("SHOW CREATE TABLE", s"$t")
}
}

val e = intercept[AnalysisException] {
sql(s"SHOW CREATE TABLE $t")
}
assert(e.message.contains("SHOW CREATE TABLE is only supported with v1 tables"))
private def testV1Command(sqlCommand: String, sqlParams: String): Unit = {
val e = intercept[AnalysisException] {
sql(s"$sqlCommand $sqlParams")
}
assert(e.message.contains(s"$sqlCommand is only supported with v1 tables"))
}

private def assertAnalysisError(sqlStatement: String, expectedError: String): Unit = {
Expand Down