Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Oct 19, 2019

What changes were proposed in this pull request?

Add LoadDataStatement and make LOAD DATA INTO TABLE go through the same catalog/table resolution framework of v2 commands.

Why are the changes needed?

It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.

USE my_catalog
DESC t // success and describe the table t from my_catalog
LOAD DATA INPATH 'filepath'  INTO TABLE t // report table not found as there is no table t in the session catalog

Does this PR introduce any user-facing change?

yes. When running LOAD DATA INTO TABLE, Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.

How was this patch tested?

Unit tests.

@SparkQA
Copy link

SparkQA commented Oct 20, 2019

Test build #112323 has finished for PR 26178 at commit aad7423.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class LoadDataStatement(

@SparkQA
Copy link

SparkQA commented Oct 20, 2019

Test build #112324 has finished for PR 26178 at commit df3f1e5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class LoadDataStatement(

@viirya
Copy link
Member Author

viirya commented Oct 20, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Oct 20, 2019

Test build #112327 has finished for PR 26178 at commit df3f1e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class LoadDataStatement(

@SparkQA
Copy link

SparkQA commented Oct 24, 2019

Test build #112570 has finished for PR 26178 at commit c29f3cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • skeleton_class = type_constructor(name, bases, type_kwargs)
  • enum_class = metacls.__new__(metacls, name, bases, classdict)
  • case class BitAndAgg(child: Expression) extends DeclarativeAggregate with ExpectsInputTypes
  • case class BitOrAgg(child: Expression) extends DeclarativeAggregate with ExpectsInputTypes
  • case class CreateNamedStruct(children: Seq[Expression]) extends Expression
  • abstract class AbstractSqlParser(conf: SQLConf) extends ParserInterface with Logging
  • class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser(conf)
  • case class CreateNamespaceStatement(
  • case class TruncateTableStatement(
  • case class ShowPartitionsStatement(
  • case class RefreshTableStatement(tableName: Seq[String]) extends ParsedStatement
  • case class CreateNamespace(
  • case class RefreshTable(
  • class SparkSqlParser(conf: SQLConf) extends AbstractSqlParser(conf)
  • case class CreateNamespaceExec(
  • case class RefreshTableExec(

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Oct 24, 2019

Test build #112574 has finished for PR 26178 at commit 83b9f19.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 24, 2019

Test build #112620 has started for PR 26178 at commit 5c8f5dd.

@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112631 has finished for PR 26178 at commit 018b327.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class UncacheTableStatement(

@SparkQA
Copy link

SparkQA commented Oct 25, 2019

Test build #112690 has finished for PR 26178 at commit 2a0a52b.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • abstract class BitAggregate extends DeclarativeAggregate with ExpectsInputTypes
  • case class BitAndAgg(child: Expression) extends BitAggregate
  • case class BitOrAgg(child: Expression) extends BitAggregate
  • case class BitXorAgg(child: Expression) extends BitAggregate
  • case class ShowCreateTableStatement(tableName: Seq[String]) extends ParsedStatement

@SparkQA
Copy link

SparkQA commented Oct 26, 2019

Test build #112719 has finished for PR 26178 at commit a95d001.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member Author

viirya commented Oct 28, 2019

cc @cloud-fan

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 2be1fe6 Oct 28, 2019
@viirya viirya deleted the SPARK-29521 branch December 27, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants