-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29521][SQL] LOAD DATA INTO TABLE should look up catalog/table like v2 commands #26178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #112323 has finished for PR 26178 at commit
|
|
Test build #112324 has finished for PR 26178 at commit
|
|
retest this please |
|
Test build #112327 has finished for PR 26178 at commit
|
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #112570 has finished for PR 26178 at commit
|
imback82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Test build #112574 has finished for PR 26178 at commit
|
|
Test build #112620 has started for PR 26178 at commit |
|
Test build #112631 has finished for PR 26178 at commit
|
|
Test build #112690 has finished for PR 26178 at commit
|
|
Test build #112719 has finished for PR 26178 at commit
|
|
cc @cloud-fan |
|
thanks, merging to master! |
What changes were proposed in this pull request?
Add LoadDataStatement and make LOAD DATA INTO TABLE go through the same catalog/table resolution framework of v2 commands.
Why are the changes needed?
It's important to make all the commands have the same table resolution behavior, to avoid confusing end-users. e.g.
Does this PR introduce any user-facing change?
yes. When running LOAD DATA INTO TABLE, Spark fails the command if the current catalog is set to a v2 catalog, or the table name specified a v2 catalog.
How was this patch tested?
Unit tests.