Skip to content

[SPARK-29529][DOCS]Remove unnecessary orc version and hive version in doc #26146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
denglingang wants to merge 5 commits into from
Closed

[SPARK-29529][DOCS]Remove unnecessary orc version and hive version in doc #26146

denglingang wants to merge 5 commits into from

Conversation

@denglingang
Copy link
Member

@denglingang denglingang commented Oct 17, 2019 •
edited
Loading

What changes were proposed in this pull request?

This PR remove unnecessary orc version and hive version in doc.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A.

@wangyum
Copy link
Member

wangyum commented Oct 17, 2019

ok to test

@SparkQA
Copy link

SparkQA commented Oct 17, 2019

Test build #112210 has finished for PR 26146 at commit 2badd47.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member

wangyum commented Oct 17, 2019

cc @dongjoon-hyun

srowen
srowen reviewed Oct 17, 2019
View reviewed changes
docs/sql-data-sources-orc.md Outdated
<td><code>spark.sql.orc.impl</code></td>
<td><code>native</code></td>
<td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.4. `hive` means the ORC library in Hive 1.2.1.</td>
<td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.5. `hive` means the ORC library in Hive 1.2.1.</td>
Copy link
Member

@srowen srowen Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove versions from this statement entirely? it's not the right place

Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removal.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, BTW, it seems that we need to rewrite all. Hive 1.2.1 also became wrong because Hadoop 3.2 profile means ORC 1.6, too. Oops. Late duplicated comment.

cc @wangyum

@SparkQA
Copy link

SparkQA commented Oct 18, 2019

Test build #112265 has finished for PR 26146 at commit 25dcd2c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

srowen
srowen reviewed Oct 18, 2019
View reviewed changes
dongjoon-hyun
dongjoon-hyun requested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denglingang . Please file another JIRA for this and use it as the PR title prefix.
This seems not a follow-up of SPARK-24576 now.

@denglingang denglingang changed the title [SPARK-24576][DOCS][FOLLOW-UP] Fix incorrect ORC version in the doc [SPARK-29529][DOCS]Remove unnecessary orc version and hive version in doc Oct 21, 2019
@SparkQA
Copy link

SparkQA commented Oct 21, 2019

Test build #112358 has finished for PR 26146 at commit 6974b7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon
HyukjinKwon reviewed Oct 21, 2019
View reviewed changes
srowen
srowen approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK pending tests

@SparkQA
Copy link

SparkQA commented Oct 22, 2019

Test build #112425 has finished for PR 26146 at commit 806edae.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Oct 22, 2019

I'm going to merge this. linter and build passed, and we don;t build the doc in PR builder.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Oct 22, 2019

Merged to master.

@SparkQA
Copy link

SparkQA commented Oct 22, 2019

Test build #112427 has finished for PR 26146 at commit c5ddd1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Oct 22, 2019

Late LGTM. Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun requested changes

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

BUILD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@denglingang @wangyum @SparkQA @HyukjinKwon @dongjoon-hyun @srowen