Skip to content

[SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab #26138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PavithraRamachandran wants to merge 1 commit into from
Closed

[SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab #26138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions ...iftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,10 +443,13 @@ private[ui] class SessionStatsPagedTable(
val sessionTableHeaders =
Seq("User", "IP", "Session ID", "Start Time", "Finish Time", "Duration", "Total Execute")

val tooltips = Seq(None, None, None, None, None, Some(THRIFT_SESSION_DURATION),
Some(THRIFT_SESSION_TOTAL_EXECUTE))
assert(sessionTableHeaders.length == tooltips.length)
val colWidthAttr = s"${100.toDouble / sessionTableHeaders.size}%"

val headerRow: Seq[Node] = {
sessionTableHeaders.map { header =>
sessionTableHeaders.zip(tooltips).map { case (header, tooltip) =>
if (header == sortColumn) {
val headerLink = Unparsed(
parameterPath +
Expand All @@ -455,24 +458,42 @@ private[ui] class SessionStatsPagedTable(
s"&$sessionStatsTableTag.pageSize=$pageSize" +
s"#$sessionStatsTableTag")
val arrow = if (desc) "▾" else "▴" // UP or DOWN
<th width={colWidthAttr}>
<a href={headerLink}>
{
if (tooltip.nonEmpty) {
<span data-toggle="tooltip" data-placement="top" title={tooltip.get}>
{header}&nbsp;{Unparsed(arrow)}
</span>
} else {
<span>
{header}&nbsp;{Unparsed(arrow)}
</span>
}
}
</a>
</th>

<th width={colWidthAttr}>
<a href={headerLink}>
{header}&nbsp;{Unparsed(arrow)}
</a>
</th>
} else {
val headerLink = Unparsed(
parameterPath +
s"&$sessionStatsTableTag.sort=${URLEncoder.encode(header, UTF_8.name())}" +
s"&$sessionStatsTableTag.pageSize=$pageSize" +
s"#$sessionStatsTableTag")

<th width={colWidthAttr}>
<a href={headerLink}>
{header}
</a>
</th>
<th width={colWidthAttr}>
<a href={headerLink}>
{
if (tooltip.nonEmpty) {
<span data-toggle="tooltip" data-placement="top" title={tooltip.get}>
{header}
</span>
} else {
{header}
}
}
</a>
</th>
}
}
}
Expand Down
7 changes: 7 additions & 0 deletions ...hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ToolTips.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,11 @@ private[ui] object ToolTips {

val THRIFT_SERVER_DURATION =
"Difference between start time and close time"

val THRIFT_SESSION_TOTAL_EXECUTE =
"Number of operations submitted in this session"

val THRIFT_SESSION_DURATION =
"Elapsed time since session start, or until closed if the session was closed"

}