[SPARK-29302][CORE][SQL] Fix writing file collision in dynamic partition overwrite mode within speculative execution #26090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
reviewed
Oct 11, 2019
Member
There was a problem hiding this comment.
AFAIK, this staging dir is used to deal with files with absolute output path, or writing data into partitioned directory with dynamicPartitionOverwrite=true.
But in this PR, it change the behavior for absolute output path.
Author
There was a problem hiding this comment.
You are right, stagingDir cannot be used here, as it might get deleted during abortJob.
|
Can one of the admins verify this patch? |
…te mode within speculative execution Reuse FileOutputCommiter to guarantee no write collision in the staging directory. Rename to final output in HadoopMapReduceCommitProtocol#commitJob.
Clarkkkkk
force-pushed
the
SPARK-29302
branch
from
2e801c5 to
7bf55bc
Compare
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When inserting into a partitioned DataSource table (would not reproduced if using a Hive table) with dynamic partition overwrite and speculative execution, attempts of same task will try to write same files.
This PR reuse FileOutputCommitter to avoid write collision, and rename files in staging directory to final output directory using the original logic in HadoopMapReduceCommitProtocol#commitJob.
Why are the changes needed?
Task failed is this circumstance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This patch is tested by existing tests in org.apache.spark.sql.sources.InsertSuite.