[SPARK-29192][TESTS] Extend BenchmarkBase to write JDK9+ results separately #25873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Member
Author
srowen
approved these changes
Sep 20, 2019
Member
Author
|
Thank you for review and approval. I'll proceed in this way! |
dongjoon-hyun
changed the title
|
Test build #111090 has finished for PR 25873 at commit
|
|
Test build #111094 has finished for PR 25873 at commit
|
Member
Author
|
Thank you for review, @srowen . For the other module, I'll proceed one by one. Some test suite seems to change the number of iterations because it requires too much time. Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to extend the existing benchmarks to save JDK9+ result separately.
All
coremodule benchmark test results are added. I'll run the other test suites in another PR.After regenerating all results, we will check JDK11 performance regressions.
Why are the changes needed?
From Apache Spark 3.0, we support both JDK8 and JDK11. We need to have a way to find the performance regression.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually run the benchmark.