[SPARK-29158][SQL][FOLLOW-UP] Create an actual test case under src/test and minor documentation correction
#25867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #111063 has finished for PR 25867 at commit
|
Member
Author
|
retest this please |
srowen
approved these changes
Sep 20, 2019
cloud-fan
approved these changes
Sep 20, 2019
dongjoon-hyun
approved these changes
Sep 20, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for the quick follow-up, @HyukjinKwon !
Member
|
cc @holdenk |
|
Test build #111070 has finished for PR 25867 at commit
|
Member
|
Since the last one is only adding comments, I'll merge this. |
Contributor
|
LGTM, thanks for fixing this @dongjoon-hyun |
|
Test build #111072 has finished for PR 25867 at commit
|
Member
Author
|
My name is @HyukjinKwon Holden :D |
Contributor
|
Sorry got PRs mixed up today, my bad.
On Fri, Sep 20, 2019 at 2:43 PM Hyukjin Kwon ***@***.***> wrote:
My name is @HyukjinKwon <https://github.com/HyukjinKwon> Holden :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25867?email_source=notifications&email_token=AAAOT5MJHGKG6ROXR2AG7FDQKU7WXA5CNFSM4IYVOEMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7H6H3Q#issuecomment-533717998>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOT5JCZMH4UX2L3P4NIPLQKU7WXANCNFSM4IYVOEMA>
.
--
Cell : 425-233-8271
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #25838 and proposes to create an actual test case under
src/test. Previously, compile only test existed atsrc/main.Also, just changed the wordings in
SerializableConfigurationjust only to describe what it does (remove other words).Why are the changes needed?
Tests codes should better exist in
src/testnotsrc/main. Also, it should better test a basic functionality.Does this PR introduce any user-facing change?
No except minor doc change.
How was this patch tested?
Unit test was added.