Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Sep 19, 2019

What changes were proposed in this pull request?

This PR backport #25404 to branch-2.4.

Why are the changes needed?

Backport from master.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests

@dongjoon-hyun
Copy link
Member

Thank you, @wangyum !

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28683][BUILD][BRANCH-2.4] Upgrade Scala to 2.12.10 [SPARK-28683][BUILD][2.4] Upgrade Scala to 2.12.10 Sep 19, 2019
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to branch-2.4.
This is a correct subset because branch-2.4 is using Scala-2.11 by default.
Also, the build is already tested via GitHub Action and Jenkins build is irrelevant because it's Scala-2.11.

dongjoon-hyun pushed a commit that referenced this pull request Sep 19, 2019
### What changes were proposed in this pull request?

This PR backport #25404 to branch-2.4.

### Why are the changes needed?
Backport from master.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
Existing tests

Closes #25839 from wangyum/SPARK-28683-branch-2.4.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@SparkQA
Copy link

SparkQA commented Sep 19, 2019

Test build #110952 has finished for PR 25839 at commit 57c4084.

  • This patch fails to generate documentation.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum deleted the SPARK-28683-branch-2.4 branch September 19, 2019 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants