Skip to content

SPARK-2626 [DOCS] Stop SparkContext in all examples #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-2626 [DOCS] Stop SparkContext in all examples #2575

wants to merge 1 commit into from

Conversation

@srowen
Copy link
Member

@srowen srowen commented Sep 29, 2014

Call SparkContext.stop() in all examples (and touch up minor nearby code style issues while at it)

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have started for PR 2575 at commit 5b2baae.

  • This patch merges cleanly.

mattf
mattf reviewed Sep 29, 2014
View reviewed changes
examples/src/main/java/org/apache/spark/examples/JavaSparkPi.java
Copy link

@mattf mattf Sep 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just whitespace

@SparkQA
Copy link

SparkQA commented Sep 29, 2014

QA tests have finished for PR 2575 at commit 5b2baae.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RandomForestModel(val trees: Array[DecisionTreeModel], val algo: Algo) extends Serializable

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 29, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20971/

@mattf
Copy link

mattf commented Sep 29, 2014

+1, lgtm

@andrewor14
Copy link
Contributor

andrewor14 commented Sep 30, 2014

Thanks for doing this. LGTM.

@JoshRosen
Copy link
Contributor

JoshRosen commented Oct 1, 2014

LGTM, too. I've merged this into master. Thanks for fixing this!

@asfgit asfgit closed this in dcb2f73 Oct 1, 2014
@JoshRosen
Copy link
Contributor

JoshRosen commented Oct 1, 2014

I also cherry-picked this into branch-1.1.

asfgit pushed a commit that referenced this pull request Oct 1, 2014
@srowen @JoshRosen
SPARK-2626 [DOCS] Stop SparkContext in all examples
13f33cf 
Call SparkContext.stop() in all examples (and touch up minor nearby code style issues while at it)

Author: Sean Owen <[email protected]>

Closes #2575 from srowen/SPARK-2626 and squashes the following commits:

5b2baae [Sean Owen] Call SparkContext.stop() in all examples (and touch up minor nearby code style issues while at it)

Conflicts:
	examples/src/main/python/parquet_inputformat.py
@srowen srowen deleted the SPARK-2626 branch October 2, 2014 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srowen @SparkQA @AmplabJenkins @mattf @andrewor14 @JoshRosen