[SPARK-21870][SQL][FOLLOW-UP] Clean up string template formats for generated code in HashAggregateExec #25714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #110246 has finished for PR 25714 at commit
|
rednaxelafx
approved these changes
Sep 6, 2019
Contributor
rednaxelafx
left a comment
rednaxelafx
left a comment
There was a problem hiding this comment.
LGTM pending Jenkins tests
Member
Author
|
Thanks for the check, @rednaxelafx ! Merged to master. |
Member
|
Ur, @maropu . Although this is a follow-up, we need +1 from the Apache Spark committers in general~ I know that you are confident on this, of course. 😄 |
Member
Author
|
Thanks for the double-check, @dongjoon-hyun ;) |
PavithraRamachandran
pushed a commit
to PavithraRamachandran/spark
that referenced
this pull request
Sep 15, 2019
…nerated code in HashAggregateExec ### What changes were proposed in this pull request? This pr cleans up string template formats for generated code in HashAggregateExec. This changes comes from rednaxelafx comment: apache#20965 (comment) ### Why are the changes needed? To improve code-readability. ### Does this PR introduce any user-facing change? No ### How was this patch tested? N/A Closes apache#25714 from maropu/SPARK-21870-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr cleans up string template formats for generated code in HashAggregateExec. This changes comes from @rednaxelafx comment: #20965 (comment)
Why are the changes needed?
To improve code-readability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A