Skip to content

Comments

[SPARK-28977][DOCS][SQL] Fix DataFrameReader.json docs to doc that partition column can be numeric, date or timestamp type#25687

Closed
srowen wants to merge 2 commits intoapache:masterfrom
srowen:SPARK-28977
Closed

[SPARK-28977][DOCS][SQL] Fix DataFrameReader.json docs to doc that partition column can be numeric, date or timestamp type#25687
srowen wants to merge 2 commits intoapache:masterfrom
srowen:SPARK-28977

Conversation

@srowen
Copy link
Member

@srowen srowen commented Sep 5, 2019

What changes were proposed in this pull request?

DataFrameReader.json() accepts a partition column that is of numeric, date or timestamp type, according to the implementation in JDBCRelation.scala. Update the scaladoc accordingly, to match the documentation in sql-data-sources-jdbc.md too.

Why are the changes needed?

scaladoc is incorrect.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@srowen srowen self-assigned this Sep 5, 2019
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we should specify numeric, date or timestamp at these two occurrences too

#' @param partitionColumn the name of a column of integral type that will be used for partitioning

:param column: the name of an integer column that will be used for partitioning;
if this parameter is specified, then ``numPartitions``, ``lowerBound``
(inclusive), and ``upperBound`` (exclusive) will form partition strides
for generated WHERE clause expressions used to split the column
``column`` evenly

LGTM otherwise

@SparkQA
Copy link

SparkQA commented Sep 5, 2019

Test build #110156 has finished for PR 25687 at commit 3b03c73.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 5, 2019

Test build #110159 has finished for PR 25687 at commit 8935d4c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

srowen added a commit that referenced this pull request Sep 5, 2019
…rtition column can be numeric, date or timestamp type

### What changes were proposed in this pull request?

`DataFrameReader.json()` accepts a partition column that is of numeric, date or timestamp type, according to the implementation in `JDBCRelation.scala`. Update the scaladoc accordingly, to match the documentation in `sql-data-sources-jdbc.md` too.

### Why are the changes needed?

scaladoc is incorrect.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

N/A

Closes #25687 from srowen/SPARK-28977.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@srowen
Copy link
Member Author

srowen commented Sep 5, 2019

I also backported to 2.4

PavithraRamachandran pushed a commit to PavithraRamachandran/spark that referenced this pull request Sep 15, 2019
…rtition column can be numeric, date or timestamp type

### What changes were proposed in this pull request?

`DataFrameReader.json()` accepts a partition column that is of numeric, date or timestamp type, according to the implementation in `JDBCRelation.scala`. Update the scaladoc accordingly, to match the documentation in `sql-data-sources-jdbc.md` too.

### Why are the changes needed?

scaladoc is incorrect.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

N/A

Closes apache#25687 from srowen/SPARK-28977.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
rluta pushed a commit to rluta/spark that referenced this pull request Sep 17, 2019
…rtition column can be numeric, date or timestamp type

### What changes were proposed in this pull request?

`DataFrameReader.json()` accepts a partition column that is of numeric, date or timestamp type, according to the implementation in `JDBCRelation.scala`. Update the scaladoc accordingly, to match the documentation in `sql-data-sources-jdbc.md` too.

### Why are the changes needed?

scaladoc is incorrect.

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

N/A

Closes apache#25687 from srowen/SPARK-28977.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@srowen srowen deleted the SPARK-28977 branch September 27, 2019 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants