Skip to content

Comments

[SPARK-28979][SQL] Rename UnresovledTable to V1Table#25683

Closed
rdblue wants to merge 1 commit intoapache:masterfrom
rdblue:SPARK-28979-rename-unresolved-table
Closed

[SPARK-28979][SQL] Rename UnresovledTable to V1Table#25683
rdblue wants to merge 1 commit intoapache:masterfrom
rdblue:SPARK-28979-rename-unresolved-table

Conversation

@rdblue
Copy link
Contributor

@rdblue rdblue commented Sep 4, 2019

What changes were proposed in this pull request?

Rename UnresolvedTable to V1Table because it is not unresolved.

Why are the changes needed?

The class name is inaccurate. This should be fixed before it is in a release.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@rdblue
Copy link
Contributor Author

rdblue commented Sep 4, 2019

@brkyvz, @cloud-fan, can you review?

@brkyvz
Copy link
Contributor

brkyvz commented Sep 4, 2019

LGTM.

@SparkQA
Copy link

SparkQA commented Sep 5, 2019

Test build #110148 has finished for PR 25683 at commit a4c4022.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan closed this in 5adaa2e Sep 5, 2019
@cloud-fan
Copy link
Contributor

thanks, merging to master!

@rdblue
Copy link
Contributor Author

rdblue commented Sep 6, 2019

Thanks for merging this, @cloud-fan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants