Skip to content

Comments

[SPARK-28964] Add the provider information to the table properties in saveAsTable#25669

Closed
brkyvz wants to merge 5 commits intoapache:masterfrom
brkyvz:provider
Closed

[SPARK-28964] Add the provider information to the table properties in saveAsTable#25669
brkyvz wants to merge 5 commits intoapache:masterfrom
brkyvz:provider

Conversation

@brkyvz
Copy link
Contributor

@brkyvz brkyvz commented Sep 3, 2019

What changes were proposed in this pull request?

Adds the provider information to the table properties in saveAsTable.

Why are the changes needed?

Otherwise, catalog implementations don't know what kind of Table definition to create.

Does this PR introduce any user-facing change?

nope

How was this patch tested?

Existing unit tests check the existence of the provider now.

@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110060 has finished for PR 25669 at commit 1d3a2b5.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 3, 2019

Test build #110061 has finished for PR 25669 at commit 137f452.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110062 has finished for PR 25669 at commit 10d5a6a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 4, 2019

Test build #110140 has finished for PR 25669 at commit 1948f70.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@brkyvz
Copy link
Contributor Author

brkyvz commented Sep 4, 2019

cc @cloud-fan @rdblue

@rdblue
Copy link
Contributor

rdblue commented Sep 4, 2019

+1

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in b9edd44 Sep 5, 2019
PavithraRamachandran pushed a commit to PavithraRamachandran/spark that referenced this pull request Sep 15, 2019
… saveAsTable

### What changes were proposed in this pull request?

Adds the provider information to the table properties in saveAsTable.

### Why are the changes needed?

Otherwise, catalog implementations don't know what kind of Table definition to create.

### Does this PR introduce any user-facing change?

nope

### How was this patch tested?

Existing unit tests check the existence of the provider now.

Closes apache#25669 from brkyvz/provider.

Authored-by: Burak Yavuz <brkyvz@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants