Skip to content

Conversation

@kiszk
Copy link
Member

@kiszk kiszk commented Aug 28, 2019

What changes were proposed in this pull request?

This PR re-enables do-release-docker.sh for branch-2.3.

According to the release manager of Spark 2.3.3 @maropu, do-release-docker.sh in the master branch. After applying #23098, the script does not work for branch-2.3.

Why are the changes needed?

This PR simplifies the release process in branch-2.3 simple.

While Spark 2.3.x will not be released further, as @dongjoon-hyun suggested, it would be good to put this change for

  1. to reproduce this release by others
  2. to make the future urgent release simple

Does this PR introduce any user-facing change?

No

How was this patch tested?

No test is added.
This PR is used to create Spark 2.3.4-rc1

@kiszk
Copy link
Member Author

kiszk commented Aug 28, 2019

cc @srowen @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Aug 28, 2019

Test build #109852 has finished for PR 25607 at commit c593646.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for the 2.3.4 release, or simply there for the future? There probably won't be another 2.3.x release anyway.

How did we release this in 2.3.x before, or is this helping release a 'new' artifact?


DRY_RUN=${DRY_RUN:-0}
GPG="gpg --no-tty --batch"
ASF_REPO="https://gitbox.apache.org/repos/asf/spark.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be github, but we can fix this separately everywhere (all branches). This should still work.

@kiszk
Copy link
Member Author

kiszk commented Aug 28, 2019

I asked @maropu who is the release manager of Spark 2.3.3. He said that he used do-release-docker.sh in the master branch for releasing Spark 2.3.3.
As I wrote in the description, I used these scripts to release Spark 2.3.4-rc1.

@srowen
Copy link
Member

srowen commented Aug 28, 2019

OK sounds good. I don't think I'd restart the RC over this change, although would be nice to get into the release if you had to make another one.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 28, 2019

Hi, @srowen and @kiszk .

According to the PR description, since this PR is verified via 2.3.4-rc, can we just publish 2.3.4 and merge this after that?

This PR is used to create Spark 2.3.4-rc1

Previously, nobody (except the release manager) knows what release script is used before 2.4.3 because master branch is changed time to time.

For 2.4.3, we also use the post-commit after 2.4.3-rc1 tagging according to the voting email.

The release is using the release script of the branch 2.4.3-rc1 with the
following commit e417168

For 2.4.4, I also mentioned like that. This is an improvement and we can update the vote mail template for future release managers.

This release is using the release script of the tag v2.4.4-rc3.
This release is using the release script of the tag v2.4.4-rc2.
This release is using the release script of the tag v2.4.4-rc1.

@dongjoon-hyun
Copy link
Member

Although this is a EOL release, this will not be a blocker for Apache vote.

@kiszk
Copy link
Member Author

kiszk commented Aug 28, 2019

@srowen thank you for your comment. got it.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 30, 2019

Since the vote passed, I'll merge this to branch-2.3 as the last commit on branch-2.3.

dongjoon-hyun pushed a commit that referenced this pull request Aug 30, 2019
### What changes were proposed in this pull request?
This PR re-enables `do-release-docker.sh` for branch-2.3.

According to the release manager of Spark 2.3.3 maropu, `do-release-docker.sh` in the master branch. After applying #23098, the script does not work for branch-2.3.

### Why are the changes needed?
This PR simplifies the release process in branch-2.3 simple.

While Spark 2.3.x will not be released further, as dongjoon-hyun [suggested](#23098 (comment)), it would be good to put this change for

1. to reproduce this release by others
2. to make the future urgent release simple

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
No test is added.
This PR is used to create Spark 2.3.4-rc1

Closes #25607 from kiszk/SPARK-28891.

Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member

Thank you, @kiszk and @srowen .

alee-altiscale pushed a commit to Altiscale/spark that referenced this pull request Apr 15, 2020
### What changes were proposed in this pull request?
This PR re-enables `do-release-docker.sh` for branch-2.3.

According to the release manager of Spark 2.3.3 maropu, `do-release-docker.sh` in the master branch. After applying apache#23098, the script does not work for branch-2.3.

### Why are the changes needed?
This PR simplifies the release process in branch-2.3 simple.

While Spark 2.3.x will not be released further, as dongjoon-hyun [suggested](apache#23098 (comment)), it would be good to put this change for

1. to reproduce this release by others
2. to make the future urgent release simple

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
No test is added.
This PR is used to create Spark 2.3.4-rc1

Closes apache#25607 from kiszk/SPARK-28891.

Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
SteBaum pushed a commit to TOSIT-IO/spark that referenced this pull request Mar 7, 2024
### What changes were proposed in this pull request?
This PR re-enables `do-release-docker.sh` for branch-2.3.

According to the release manager of Spark 2.3.3 maropu, `do-release-docker.sh` in the master branch. After applying apache#23098, the script does not work for branch-2.3.

### Why are the changes needed?
This PR simplifies the release process in branch-2.3 simple.

While Spark 2.3.x will not be released further, as dongjoon-hyun [suggested](apache#23098 (comment)), it would be good to put this change for

1. to reproduce this release by others
2. to make the future urgent release simple

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
No test is added.
This PR is used to create Spark 2.3.4-rc1

Closes apache#25607 from kiszk/SPARK-28891.

Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants