-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-28891][BUILD][2.3] backport do-release-docker.sh to branch-2.3 #25607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #109852 has finished for PR 25607 at commit
|
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required for the 2.3.4 release, or simply there for the future? There probably won't be another 2.3.x release anyway.
How did we release this in 2.3.x before, or is this helping release a 'new' artifact?
|
|
||
| DRY_RUN=${DRY_RUN:-0} | ||
| GPG="gpg --no-tty --batch" | ||
| ASF_REPO="https://gitbox.apache.org/repos/asf/spark.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be github, but we can fix this separately everywhere (all branches). This should still work.
|
I asked @maropu who is the release manager of Spark 2.3.3. He said that he used |
|
OK sounds good. I don't think I'd restart the RC over this change, although would be nice to get into the release if you had to make another one. |
|
According to the PR description, since this PR is verified via
Previously, nobody (except the release manager) knows what release script is used before 2.4.3 because For 2.4.3, we also use the post-commit after
For 2.4.4, I also mentioned like that. This is an improvement and we can update the vote mail template for future release managers.
|
|
Although this is a EOL release, this will not be a blocker for Apache vote. |
|
@srowen thank you for your comment. got it. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Since the vote passed, I'll merge this to |
### What changes were proposed in this pull request? This PR re-enables `do-release-docker.sh` for branch-2.3. According to the release manager of Spark 2.3.3 maropu, `do-release-docker.sh` in the master branch. After applying #23098, the script does not work for branch-2.3. ### Why are the changes needed? This PR simplifies the release process in branch-2.3 simple. While Spark 2.3.x will not be released further, as dongjoon-hyun [suggested](#23098 (comment)), it would be good to put this change for 1. to reproduce this release by others 2. to make the future urgent release simple ### Does this PR introduce any user-facing change? No ### How was this patch tested? No test is added. This PR is used to create Spark 2.3.4-rc1 Closes #25607 from kiszk/SPARK-28891. Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
### What changes were proposed in this pull request? This PR re-enables `do-release-docker.sh` for branch-2.3. According to the release manager of Spark 2.3.3 maropu, `do-release-docker.sh` in the master branch. After applying apache#23098, the script does not work for branch-2.3. ### Why are the changes needed? This PR simplifies the release process in branch-2.3 simple. While Spark 2.3.x will not be released further, as dongjoon-hyun [suggested](apache#23098 (comment)), it would be good to put this change for 1. to reproduce this release by others 2. to make the future urgent release simple ### Does this PR introduce any user-facing change? No ### How was this patch tested? No test is added. This PR is used to create Spark 2.3.4-rc1 Closes apache#25607 from kiszk/SPARK-28891. Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
### What changes were proposed in this pull request? This PR re-enables `do-release-docker.sh` for branch-2.3. According to the release manager of Spark 2.3.3 maropu, `do-release-docker.sh` in the master branch. After applying apache#23098, the script does not work for branch-2.3. ### Why are the changes needed? This PR simplifies the release process in branch-2.3 simple. While Spark 2.3.x will not be released further, as dongjoon-hyun [suggested](apache#23098 (comment)), it would be good to put this change for 1. to reproduce this release by others 2. to make the future urgent release simple ### Does this PR introduce any user-facing change? No ### How was this patch tested? No test is added. This PR is used to create Spark 2.3.4-rc1 Closes apache#25607 from kiszk/SPARK-28891. Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
This PR re-enables
do-release-docker.shfor branch-2.3.According to the release manager of Spark 2.3.3 @maropu,
do-release-docker.shin the master branch. After applying #23098, the script does not work for branch-2.3.Why are the changes needed?
This PR simplifies the release process in branch-2.3 simple.
While Spark 2.3.x will not be released further, as @dongjoon-hyun suggested, it would be good to put this change for
Does this PR introduce any user-facing change?
No
How was this patch tested?
No test is added.
This PR is used to create Spark 2.3.4-rc1