[SPARK-28527][SQL][TEST][FOLLOW-UP] Ignores Thrift server ThriftServerQueryTestSuite #25592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Aug 27, 2019
Member
There was a problem hiding this comment.
I agree that this is one possible solution, @wangyum . Thank you for taking a look at this quickly.
BTW, could you guess what is the root cause? If we are not going to revert this, we need to file a new JIRA issue: Fix a flaky test: ThriftServerQueryTestSuite.
|
Test build #109783 has finished for PR 25592 at commit
|
Member
|
@wangyum can you file a JIRA and take a look why it's flaky? As @dongjoon-hyun pointed out, I don't think it's correct to leave the flakiness ignored like this. If you can't, let us know and we should revert this and #25567 PRs. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR ignores Thrift server
ThriftServerQueryTestSuite.Why are the changes needed?
This ThriftServerQueryTestSuite test case led to frequent Jenkins build failure.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
N/A