-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28701][INFRA][FOLLOWUP] Fix the key error when looking in os.environ #25585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
it behooves us, when checking for env vars in non-prb builds, to always check for the key before referencing it in an |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, right.
|
once we get to the |
|
thanks @dongjoon-hyun |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Test build #109747 has finished for PR 25585 at commit
|
this has to be unrelated... should i test again or just go ahead and merge? |
|
It clearly fixes the issue that was failing before, right? you can see the desired output in the logs that even starts the tests? then I'd merge it. That can't be related. |
|
alrighty! things looking good. the builds i broke (spark-master-test-sbt-*) are good, and i spot-checked one (https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-3.2/324/) and the spark unit tests just started successfully: |
What changes were proposed in this pull request?
i broke run-tests.py for non-PRB builds in this PR:
#25423
Why are the changes needed?
to fix what i broke
Does this PR introduce any user-facing change?
no
How was this patch tested?
the build system will test this