Skip to content

Conversation

@PavithraRamachandran
Copy link
Contributor

@PavithraRamachandran PavithraRamachandran commented Aug 22, 2019

What changes were proposed in this pull request?

Document TRUNCATE statement in SQL Reference Guide.

Why are the changes needed?

Adding documentation for SQL reference.

Does this PR introduce any user-facing change?

yes

Before:
There was no documentation for this.

After.
image (4)
image (5)

How was this patch tested?

Used jekyll build and serve to verify.

@dilipbiswal
Copy link
Contributor

@PavithraRamachandran Hello could you please update this by following the convention of existing merged PRS.
#25529
#25525

@PavithraRamachandran
Copy link
Contributor Author

@dilipbiswal and @srowen i have reworked on the documentation. Kindly review

@srowen
Copy link
Member

srowen commented Sep 16, 2019

Is this copied from Hive or Databricks docs? it looks like some phrases are. I get that there are just not many ways to express the exact same idea, but rewording the prose a little bit would be better.

@PavithraRamachandran
Copy link
Contributor Author

@srowen i have reworked. Could you review.

**This page is under construction**
### Description
The `TRUNCATE TABLE` statement removes all the rows from a table or partition(s). The table must not be a view
or an external/temporary table. Inorder to truncate multiple partitions at once, user can specify the partitions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inorder -> In order
user -> the user
back-tick partition_spec

-- Removes all rows from the table in the partion specified
TRUNCATE TABLE Student partition(age=10);

--After truncate execution, records belonging to partition age=10 is removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is -> are

@PavithraRamachandran
Copy link
Contributor Author

@srowen I have handled the review comments. Could you verify?

@SparkQA
Copy link

SparkQA commented Sep 17, 2019

Test build #4875 has finished for PR 25557 at commit 39af010.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Sep 18, 2019

Merged to master

@srowen srowen closed this in b48ef7a Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants