Skip to content

Conversation

@sandeep-katta
Copy link
Contributor

@sandeep-katta sandeep-katta commented Aug 22, 2019

What changes were proposed in this pull request?

Document DROP DATABASE statement in SQL Reference

Why are the changes needed?

Currently from spark there is no complete sql guide is present, so it is better to document all the sql commands, this jira is sub part of this task.

Does this PR introduce any user-facing change?

Yes, Before there was no documentation about drop database syntax

After Fix
image
image

How was this patch tested?

tested with jenkyll build

@dilipbiswal
Copy link
Contributor

@sandeep-katta Hey, could you please update this by following the convention of existing merged PRS.
#25529
#25525

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Sep 12, 2019

LGTM
cc @gatorsmile

@gatorsmile
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Sep 12, 2019

Test build #110520 has finished for PR 25554 at commit 4490353.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

@gatorsmile Thanks a lot.

PavithraRamachandran pushed a commit to PavithraRamachandran/spark that referenced this pull request Sep 15, 2019
### What changes were proposed in this pull request?
Document DROP DATABASE statement in SQL Reference

### Why are the changes needed?
Currently from spark there is no complete sql guide is present, so it is better to document all the sql commands, this jira is sub part of this task.

### Does this PR introduce any user-facing change?
Yes, Before there was no documentation about drop database syntax

After Fix
![image](https://user-images.githubusercontent.com/35216143/64787097-977a7200-d58d-11e9-911c-d2ff6f3ccff5.png)
![image](https://user-images.githubusercontent.com/35216143/64787122-a6612480-d58d-11e9-978c-9455baff007f.png)

### How was this patch tested?
tested with jenkyll build

Closes apache#25554 from sandeep-katta/dropDbDoc.

Authored-by: sandeep katta <[email protected]>
Signed-off-by: Xiao Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants