[SPARK-28798][DOC][SQL]Document DROP TABLE/VIEW statement in SQL Reference. #25533

shivusondur · 2019-08-21T09:24:41Z

What changes were proposed in this pull request?

Added doc for DROP TABLE and DROP VIEW sql command

Why are the changes needed?

For reference DROP TABLE or DROP VIEW in spark-sql

Does this PR introduce any user-facing change?

It updates DROP TABLE or DROP VIEW reference doc

How was this patch tested?

Attached the Snap

DROP TABLE

DROP VIEW

dilipbiswal · 2019-08-21T17:57:04Z

@shivusondur Could you please attach the screenshot of the page to make it easier for reviewers ?

docs/sql-ref-syntax-ddl-drop-table.md

dilipbiswal · 2019-08-29T16:47:36Z

@shivusondur A few related DOC PRs were merged by @gatorsmile
#25525
#25523

Could you please make changes by following the format of these PRs ? A few things to note:

Formatting of the parameters under dl tag now.
Examples should contain output. Please refer to the INSERT PR for examples.
Add some related statements - statements users are likely to visit. For example after a drop users may want to do a show tables to check the catalog or be interested in some other view commands.
After making the change, kindly put the updated screenshots in the PR description so it saves comitters some time :-)

shivusondur · 2019-09-02T08:32:18Z

@dilipbiswal @srowen @gatorsmile
Updated the PR according to #25525 and #25523 PR's.
Updated the ScreenShot after creating the document from Jekyll build

Please review and kindly check for merging.

dilipbiswal · 2019-09-12T07:41:12Z

docs/sql-ref-syntax-ddl-drop-table.md

+### Description
+
+Deletes the table and removes the directory associated with this table from the file system
+if this is not `EXTERNAL` table. If the table is not present it throws exception.


Nit: an exception

dilipbiswal · 2019-09-12T07:43:15Z

docs/sql-ref-syntax-ddl-drop-table.md

+Deletes the table and removes the directory associated with this table from the file system
+if this is not `EXTERNAL` table. If the table is not present it throws exception.
+
+In case of External table it only deletes the metadata from metastore database and it will not remove the directory 


Nit: In case of External table, only the associated metadata information are removed from the metastore database.

dilipbiswal · 2019-09-12T07:43:49Z

docs/sql-ref-syntax-ddl-drop-table.md

+  </dd>
+  <dt><code><em>database_name</em></code></dt>
+  <dd>
+     Database name where table is present.


Nit: Specifies the database name where table is present.

dilipbiswal · 2019-09-12T07:44:04Z

docs/sql-ref-syntax-ddl-drop-table.md

+  </dd>
+  <dt><code><em>table_name</em></code></dt>
+  <dd>
+     table name to be dropped.


Nit: Ditto.

docs/sql-ref-syntax-ddl-drop-table.md

dilipbiswal · 2019-09-12T07:48:33Z

docs/sql-ref-syntax-ddl-drop-view.md


-**This page is under construction**
+### Description
+Drops the specified `VIEW`, which was created by `CREATE VIEW` statement. `DROP VIEW` only involves


How about the following ?
DROP VIEW` removes the metadata associated with a specified view from the catalog.

dilipbiswal · 2019-09-12T07:48:59Z

docs/sql-ref-syntax-ddl-drop-view.md

+  </dd>
+  <dt><code><em>database_name</em></code></dt>
+  <dd>
+     Database name where view is present.


Please add "Specifies"

Handled PR according to apache#25523 PR which is already merged. to make uniform accross all docs

shivusondur · 2019-09-18T17:06:02Z

@dilipbiswal
Thanks for your time.
i handled all the comments and updated the screen shot.
Please check

gatorsmile · 2019-09-20T21:02:24Z

ok to test

SparkQA · 2019-09-20T21:21:57Z

Test build #111093 has finished for PR 25533 at commit 194a0b0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

docs/sql-ref-syntax-ddl-drop-table.md

srowen · 2019-10-21T18:44:34Z

docs/sql-ref-syntax-ddl-drop-table.md

+Deletes the table and removes the directory associated with this table from the file system
+if this is not `EXTERNAL` table. If the table is not present it throws an exception.
+
+In case of External table, only the associated metadata information are removed from the metastore database.


of an external table

docs/sql-ref-syntax-ddl-drop-view.md

srowen · 2019-10-21T18:45:05Z

docs/sql-ref-syntax-ddl-drop-view.md

+
+### Example
+{% highlight sql %}
+-- Assumes a view name `employeeView` exist.


docs/sql-ref-syntax-ddl-drop-view.md

shivusondur · 2019-10-29T18:33:58Z

@srowen
Handled your comments, please check

SparkQA · 2019-10-29T18:51:26Z

Test build #112863 has finished for PR 25533 at commit df23c95.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen

Looking fine, just a few more nits

docs/sql-ref-syntax-ddl-drop-table.md

shivusondur · 2019-10-30T17:48:44Z

@srowen
Thanks for reviewing.
I handled your comments.

SparkQA · 2019-10-30T18:07:17Z

Test build #112950 has finished for PR 25533 at commit 2ca9a6e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

srowen · 2019-11-04T17:52:58Z

Merged to master

dongjoon-hyun added DOCUMENTATION SQL labels Aug 21, 2019

srowen requested changes Aug 21, 2019

View reviewed changes

docs/sql-ref-syntax-ddl-drop-table.md Outdated Show resolved Hide resolved

shivusondur added 7 commits September 2, 2019 00:08

Added doc

24122dd

ADDED THE VIEW DOC

a1fb4cf

Updated the document details

3b4252e

Updated the document details

42cda3e

Updated the document according to latest comments

5683d95

Updated the document according to latest comments

4ee7a76

Updated the document according to latest comments

c171040

shivusondur force-pushed the jiraUSEDB branch from d591db2 to c171040 Compare September 2, 2019 08:21

dilipbiswal reviewed Sep 12, 2019

View reviewed changes

docs/sql-ref-syntax-ddl-drop-table.md Show resolved Hide resolved

dilipbiswal reviewed Sep 12, 2019

View reviewed changes

Handled the dilipbiswal's comments

194a0b0

Handled PR according to apache#25523 PR which is already merged. to make uniform accross all docs

shivusondur force-pushed the jiraUSEDB branch from cf3aebe to 194a0b0 Compare September 18, 2019 16:56

srowen requested changes Oct 21, 2019

View reviewed changes

handled the comments

df23c95

srowen reviewed Oct 29, 2019

View reviewed changes

docs/sql-ref-syntax-ddl-drop-table.md Outdated Show resolved Hide resolved

docs/sql-ref-syntax-ddl-drop-table.md Outdated Show resolved Hide resolved

handled the comments

2ca9a6e

shivusondur requested a review from srowen November 4, 2019 17:18

srowen approved these changes Nov 4, 2019

View reviewed changes

srowen closed this in f29a979 Nov 4, 2019

[SPARK-28798][DOC][SQL]Document DROP TABLE/VIEW statement in SQL Reference. #25533

[SPARK-28798][DOC][SQL]Document DROP TABLE/VIEW statement in SQL Reference. #25533

Uh oh!

Conversation

shivusondur commented Aug 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

dilipbiswal commented Aug 21, 2019

Uh oh!

Uh oh!

dilipbiswal commented Aug 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivusondur commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shivusondur commented Sep 18, 2019

Uh oh!

gatorsmile commented Sep 20, 2019

Uh oh!

SparkQA commented Sep 20, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shivusondur commented Oct 29, 2019

Uh oh!

SparkQA commented Oct 29, 2019

Uh oh!

srowen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shivusondur commented Oct 30, 2019

Uh oh!

SparkQA commented Oct 30, 2019

Uh oh!

srowen commented Nov 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shivusondur commented Aug 21, 2019 •

edited

Loading

dilipbiswal commented Aug 29, 2019 •

edited

Loading

shivusondur commented Sep 2, 2019 •

edited

Loading