Skip to content

[SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type #25480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 2 commits into from
Closed

[SPARK-28763][SQL][TEST] Flaky Tests: SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type #25480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dc7163
try 1
wangyum Aug 16, 2019
da84f92
try 2
wangyum Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftJdbcTest {
}
testExecuteStatementWithProtocolVersion(version, "SELECT cast(49960 as binary)") { rs =>
assert(rs.next())
assert(rs.getString(1) === UTF8String.fromBytes(NumberConverter.toBinary(49960)).toString)
assertResult(Array(0, 0, 65533, 40).map(_.toChar)) {
rs.getString(1).toCharArray
}
Copy link
Member Author

@wangyum wangyum Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun @HyukjinKwon Maybe we should uses CharArray.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference? Could you tell us the root cause you think?

Copy link
Member Author

@wangyum wangyum Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. May be related to environment:
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4832/
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109194/testReport/

These two PullRequestBuilders are built on the same machine(amp-jenkins-worker-03). The first one failed, but the last one successful. The environment differences:
image

Copy link
Member Author

@wangyum wangyum Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will verify it later.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, something like LANG=en_US.UTF_8?

Copy link
Member

@srowen srowen Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaneknapp I'd set it everywhere, personally, if it's easy.

Copy link
Contributor

@shaneknapp shaneknapp Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's easy, but requires each worker to be disconnected/reconnected... i'll get that set up now but it won't go in to effect until i have the opportunity to restart things.

Copy link
Member Author

@wangyum wangyum Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shaneknapp

Copy link
Member Author

@wangyum wangyum Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we close this PR?

Copy link
Member

@dongjoon-hyun dongjoon-hyun Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for investigating this so far, @wangyum . Yes. It looks like that.
You can close this and the JIRA together. If the failure is reported again, we can reopen this.

}
testExecuteStatementWithProtocolVersion(version, "SELECT cast(null as binary)") { rs =>
assert(rs.next())
Expand Down