Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Aug 16, 2019

What changes were proposed in this pull request?

This PR aims to upgrade scala-maven-plugin to 4.1.1 to bring the improvement (including Scala 2.13.0 support, Zinc update) and bug fixes in the plugin.

Why are the changes needed?

4.1.1 uses the latest dependent plugins.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests.

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @HyukjinKwon !

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #109211 has finished for PR 25476 at commit 5d6015a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@dongjoon-hyun
Copy link
Member Author

Retest this please

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I was using it yesterday and seemed to work (i.e. the problem I reported was with the -release change attempt). BTW I think you're welcome to update lots of plugins in one go if you like. It'd be good to keep them pretty up to date for 3.0.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #109218 has finished for PR 25476 at commit 5d6015a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #4834 has finished for PR 25476 at commit 5d6015a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #4835 has finished for PR 25476 at commit 5d6015a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 16, 2019

Test build #109239 has finished for PR 25476 at commit 5d6015a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Aug 16, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Aug 17, 2019

Test build #109245 has finished for PR 25476 at commit 5d6015a.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Aug 17, 2019

Test build #109257 has finished for PR 25476 at commit 5d6015a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon , @srowen , @viirya .
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-28759 branch August 17, 2019 04:27
@dongjoon-hyun
Copy link
Member Author

Thanks, @srowen . Until now, I'm trying to focus on JDK11 related stuff.

For 3.0.0, yes, I'll try to check the plugins and make it up-to-date.

BTW I think you're welcome to update lots of plugins in one go if you like. It'd be good to keep them pretty up to date for 3.0.

@HyukjinKwon
Copy link
Member

For unknown reason, AppVeyor build is being failed after this upgrade. I am investigating this at #25493.

[INFO] --- scala-maven-plugin:4.1.1:add-source (eclipse-add-source) @ spark-parent_2.12 ---
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.2.1/plexus-utils-3.2.1.pom
Progress (1): 2.2/5.3 kBProgress (1): 5.0/5.3 kBProgress (1): 5.3 kB                        Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/3.2.1/plexus-utils-3.2.1.pom (5.3 kB at 85 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-classworlds/2.6.0/plexus-classworlds-2.6.0.pom
Progress (1): 2.2/7.9 kBProgress (1): 5.0/7.9 kBProgress (1): 7.8/7.9 kBProgress (1): 7.9 kB                        Downloaded from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-classworlds/2.6.0/plexus-classworlds-2.6.0.pom (7.9 kB at 126 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-sink-api/1.9/doxia-sink-api-1.9.pom
ownloaded from central: https://repo.maven.apache.org/maven2/jline/jline/2.14.6/jline-2.14.6.jar (269 kB at 331 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/apache/logging/log4j/log4j-api/2.11.2/log4j-api-2.11.2.jar
rogress (4): 1.5/1.8 MB | 1.4/1.4 MB | 0.6/2.3 MB | 20/799 kBProgress (4): 1.5/1.8 MB | 1.4/1.4 MB | 0.6/2.3 

Logs just get truncated in the middle of downloading scala-maven-plugin.

Maybe somehow the logs are being swallowed somewhere like #24481 case.

Reverting it.

@dongjoon-hyun
Copy link
Member Author

Got it, @HyukjinKwon . Thank you for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants