-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28759][BUILD] Upgrade scala-maven-plugin to 4.1.1 #25476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending tests.
|
Thank you for review and approval, @HyukjinKwon ! |
|
Test build #109211 has finished for PR 25476 at commit
|
|
retest this please |
|
Retest this please |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I was using it yesterday and seemed to work (i.e. the problem I reported was with the -release change attempt). BTW I think you're welcome to update lots of plugins in one go if you like. It'd be good to keep them pretty up to date for 3.0.
|
Test build #109218 has finished for PR 25476 at commit
|
|
Test build #4834 has finished for PR 25476 at commit
|
|
Retest this please. |
|
Test build #4835 has finished for PR 25476 at commit
|
|
Test build #109239 has finished for PR 25476 at commit
|
|
retest this please |
|
Test build #109245 has finished for PR 25476 at commit
|
|
retest this please |
|
Test build #109257 has finished for PR 25476 at commit
|
|
Thank you, @HyukjinKwon , @srowen , @viirya . |
|
Thanks, @srowen . Until now, I'm trying to focus on JDK11 related stuff. For 3.0.0, yes, I'll try to check the plugins and make it up-to-date.
|
|
For unknown reason, AppVeyor build is being failed after this upgrade. I am investigating this at #25493. Logs just get truncated in the middle of downloading Maybe somehow the logs are being swallowed somewhere like #24481 case. Reverting it. |
|
Got it, @HyukjinKwon . Thank you for fixing it. |
What changes were proposed in this pull request?
This PR aims to upgrade
scala-maven-pluginto 4.1.1 to bring the improvement (including Scala 2.13.0 support, Zinc update) and bug fixes in the plugin.Why are the changes needed?
4.1.1uses the latest dependent plugins.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins.