[SPARK-28706][SQL] Allow cast null type to any types#25425
Closed
jiangxb1987 wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-28706][SQL] Allow cast null type to any types#25425jiangxb1987 wants to merge 2 commits intoapache:masterfrom
jiangxb1987 wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
| case (DateType, TimestampType) => true | ||
| case (_: AtomicType, StringType) => true | ||
| case (_: CalendarIntervalType, StringType) => true | ||
| case (NullType, StringType) => true |
Member
There was a problem hiding this comment.
So this is a logical partial recover of the previous code case (_, StringType) => true before #25242, right?
Contributor
There was a problem hiding this comment.
I think we can cast null type to any type, how about case (NullType, _) => true?
Member
There was a problem hiding this comment.
+1, @cloud-fan 's comment.
In that case, let's create a new JIRA instead of FOLLOWUP, @jiangxb1987 .
|
Test build #109004 has finished for PR 25425 at commit
|
jiangxb1987
changed the title
HyukjinKwon
approved these changes
Aug 13, 2019
gengliangwang
approved these changes
Aug 13, 2019
|
Test build #109015 has finished for PR 25425 at commit
|
Contributor
Author
|
retest this please |
cloud-fan
approved these changes
Aug 13, 2019
maropu
approved these changes
Aug 13, 2019
|
Test build #109026 has finished for PR 25425 at commit
|
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#25242 proposed to disallow upcasting complex data types to string type, however, upcasting from null type to any types should still be safe.
How was this patch tested?
Add corresponding case in
CastSuite.