Skip to content

[SPARK-28474][SQL] Hive 0.12 JDBC client can not handle binary type #25379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 3 commits into from
Closed

[SPARK-28474][SQL] Hive 0.12 JDBC client can not handle binary type #25379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
984e69b
Hive 0.12 JDBC client cannot read binary type
wangyum Aug 7, 2019
c75b1dd
UTF8String.fromBytes
wangyum Aug 8, 2019
7b506e8
Add more test
wangyum Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,7 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftJdbcTest {
}
}

// TODO: enable this test case after SPARK-28474
ignore(s"$version get binary type") {
test(s"$version get binary type") {
testExecuteStatementWithProtocolVersion(version, "SELECT cast('ABC' as binary)") { rs =>
assert(rs.next())
assert(rs.getString(1) === "ABC")
Expand Down
2 changes: 1 addition & 1 deletion sql/hive-thriftserver/v1.2.1/src/main/java/org/apache/hive/service/cli/ColumnValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public static TColumnValue toTColumnValue(Type type, Object value) {
case DECIMAL_TYPE:
return stringValue(((HiveDecimal)value));
case BINARY_TYPE:
return stringValue((String)value);
return stringValue(new String((byte[])value));
Copy link
Member Author

@wangyum wangyum Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stored it as Array[Byte]:

spark/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala

Lines 105 to 106 in 687dd4e

case BinaryType =>
to += from.getAs[Array[Byte]](ordinal)

case ARRAY_TYPE:
case MAP_TYPE:
case STRUCT_TYPE:
Expand Down
2 changes: 1 addition & 1 deletion sql/hive-thriftserver/v2.3.5/src/main/java/org/apache/hive/service/cli/ColumnValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public static TColumnValue toTColumnValue(TypeDescriptor typeDescriptor, Object
case DECIMAL_TYPE:
return stringValue((HiveDecimal)value, typeDescriptor);
case BINARY_TYPE:
return stringValue((String)value);
return stringValue(new String((byte[])value));
case ARRAY_TYPE:
case MAP_TYPE:
case STRUCT_TYPE:
Expand Down