[SPARK-28622][SQL][PYTHON] Rename PullOutPythonUDFInJoinCondition to ExtractPythonUDFFromJoinCondition and move to 'Extract Python UDFs'#25358
Closed
HyukjinKwon wants to merge 4 commits intoapache:masterfrom
Conversation
cloud-fan
reviewed
Aug 5, 2019
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
HyukjinKwon
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gatorsmile
reviewed
Aug 5, 2019
| override def defaultBatches: Seq[Batch] = (preOptimizationBatches ++ super.defaultBatches :+ | ||
| Batch("Optimize Metadata Only Query", Once, OptimizeMetadataOnlyQuery(catalog)) :+ | ||
| Batch("Extract Python UDFs", Once, | ||
| PullOutPythonUDFInJoinCondition, |
Member
There was a problem hiding this comment.
Rename it to ExtractPythonUDFFromJoinCondition ?
Member
There was a problem hiding this comment.
A separate question. Do we have a test case that ensure the local predicate that only contains PythonUDF will be pushed through Join? cc @cloud-fan
Contributor
There was a problem hiding this comment.
not sure. maybe we can add one in ExtractPythonUDFsSuite
HyukjinKwon
changed the title
HyukjinKwon
force-pushed
the
move-python-join-rule
branch
from
7408b3a to
4bc07bb
Compare
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
|
Test build #108673 has finished for PR 25358 at commit
|
Member
|
LGTM Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR targets to rename
PullOutPythonUDFInJoinConditiontoExtractPythonUDFFromJoinConditionand move to 'Extract Python UDFs' together with other Python UDF related rules.Currently
PullOutPythonUDFInJoinConditionrule is alone outside of other 'Extract Python UDFs' rules together.and the name
ExtractPythonUDFFromJoinConditionis matched to existing Python UDF extraction rules.How was this patch tested?
Existing tests should cover.