[SPARK-28581][SQL] Replace _FUNC_ in UDF ExpressionInfo#25314
Closed
wangyum wants to merge 1 commit intoapache:masterfrom
wangyum:SPARK-28581
Closed
[SPARK-28581][SQL] Replace _FUNC_ in UDF ExpressionInfo#25314wangyum wants to merge 1 commit intoapache:masterfrom wangyum:SPARK-28581
wangyum wants to merge 1 commit intoapache:masterfrom
wangyum:SPARK-28581
Conversation
Contributor
|
👍 from me. |
Member
|
Hi, @wangyum and @juliuszsompolski .
|
|
Test build #108469 has finished for PR 25314 at commit
|
dongjoon-hyun
approved these changes
Jul 31, 2019
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I updated the PR description and JIRA description.
Merged to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR moves
replaceFunctionName(usage: String, functionName: String)from
DescribeFunctionCommandtoExpressionInfoin order to makeExpressionInforeturns actual name instead of placeholder. We can getExpressionInfos directly throughSessionCatalog.lookupFunctionInfoAPI and get the real names.How was this patch tested?
unit tests