Skip to content

[SPARK-28581][SQL] Replace _FUNC_ in UDF ExpressionInfo#25314

Closed
wangyum wants to merge 1 commit intoapache:masterfrom
wangyum:SPARK-28581
Closed

[SPARK-28581][SQL] Replace _FUNC_ in UDF ExpressionInfo#25314
wangyum wants to merge 1 commit intoapache:masterfrom
wangyum:SPARK-28581

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jul 31, 2019

What changes were proposed in this pull request?

This PR moves replaceFunctionName(usage: String, functionName: String)
from DescribeFunctionCommand to ExpressionInfo in order to make ExpressionInfo returns actual name instead of placeholder. We can get ExpressionInfos directly through SessionCatalog.lookupFunctionInfo API and get the real names.

How was this patch tested?

unit tests

@juliuszsompolski
Copy link
Contributor

👍 from me.
cc @gatorsmile

@dongjoon-hyun
Copy link
Member

Hi, @wangyum and @juliuszsompolski .
I know this comes from #25252 . However, JIRA and PR should be self-describing. This will be a commit log. Could you add the reason why we need this to the followings?

@SparkQA
Copy link

SparkQA commented Jul 31, 2019

Test build #108469 has finished for PR 25314 at commit a5f31e3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. I updated the PR description and JIRA description.
Merged to master.

@wangyum wangyum deleted the SPARK-28581 branch August 1, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments