-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28578][INFRA] Improve Github pull request template #25310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @apache/spark-committers |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
so I think this brings up a good question as to what we want in the jira and what we want in the PR. Many times they have the same information. Do we want it to be copied to both places, referenced, etc.? |
|
This is covered in the contributing guide, though that's a big doc. It could be worth a note here that contributors should pay attention to the relationship between JIRAs and PRs as described there. Though I suppose they should really read it all. |
|
I think basically JIRA describes what issue and PR describes how it is fixed. Each focuses on each's purpose but other information can be duplicated for better and faster reviews. I think it's case-by-case. |
a7a39c0 to
eb76d8d
Compare
|
Let me cc some more active contributors who didn't put input here for better visibility and to collect more feedback. cc @viirya @mgaido91 @MaxGekk @HeartSaVioR @gaborgsomogyi @dilipbiswal |
|
Thanks.
Don't have stable Internet connection right now.
May look into it and provide feedback tomorrow or later.
…On Wed, Jul 31, 2019, 20:50 Hyukjin Kwon ***@***.***> wrote:
Let me cc some more active contributors who didn't put input here for
better visibility and to collect more feedback. cc @viirya
<https://github.com/viirya> @mgaido91 <https://github.com/mgaido91>
@MaxGekk <https://github.com/MaxGekk> @HeartSaVioR
<https://github.com/HeartSaVioR> @gaborgsomogyi
<https://github.com/gaborgsomogyi> @dilipbiswal
<https://github.com/dilipbiswal>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25310?email_source=notifications&email_token=AAAQZ5466PS7A66XOWZYGULQCJMO3A5CNFSM4IIDLKYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3JG4WQ#issuecomment-517107290>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAQZ5YUUVAOWXLWG5F3PJLQCJMO3ANCNFSM4IIDLKYA>
.
|
mgaido91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pinging me @HyukjinKwon
This comment has been minimized.
This comment has been minimized.
abe9701 to
3b675ff
Compare
3b675ff to
b4d56b2
Compare
BryanCutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @HyukjinKwon ! I just had some minor grammatical suggestions.
|
I was stuck in some works. Let me update it tomorrow in KST. |
|
I address the comments. Should be ready for a look. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
retest this please |
|
Test build #109031 has finished for PR 25310 at commit
|
BryanCutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Let me merge this one in few days if there are no more comments. |
HeartSaVioR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Merged to master. |
|
Let's see how it goes. thanks guys! |
What changes were proposed in this pull request?
This PR proposes to improve the Github template for better and faster review iterations and better interactions between PR authors and reviewers.
As suggested in the the dev mailing list, this PR referred Kubernates' PR template.
Therefore, those fields are newly added:
and some comments were added.
Why are the changes needed?
Currently, many PR descriptions are poorly formatted, which causes some overheads between PR authors and reviewers.
There are multiple problems by those poorly formatted PR descriptions:
This PR targets to alleviate the problems and situation.
Does this PR introduce any user-facing change?
Yes, it changes the PR templates when PRs are open. This PR uses the template this PR proposes.
How was this patch tested?
Manually tested via Github preview feature.