Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

it seems that doc for libsvm datasource is not added in #22675.
This pr is to add it.

How was this patch tested?

doc built locally
图片

url: ml-statistics.html
- text: Data sources
url: ml-datasource
url: ml-datasource.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orginal url: ml-datasource is incorrect that the generated url lose suffix .html
This do not matter in the offical web, since it seems that model web browser will automatically add the suffix.
However, in the locally built docs, we can not open the ml-datasource link file:///Users/xxx/Dev/OpenSource/spark/docs/_site/ml-datasource from page file:///Users/xxx/Dev/OpenSource/spark/docs/_site/ml-guide.html.

@zhengruifeng
Copy link
Contributor Author

ping @mengxr @WeichenXu123 ? would you mind help reviewing this? thanks in advance!

@SparkQA
Copy link

SparkQA commented Jul 29, 2019

Test build #108321 has finished for PR 25286 at commit 0e23538.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 29, 2019

Test build #108323 has finished for PR 25286 at commit 8cf823a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

(ignore the logs above. I was testing merge script Python 3 compatibility)

@srowen
Copy link
Member

srowen commented Aug 1, 2019

Merged to master

@srowen srowen closed this in b29829e Aug 1, 2019
@zhengruifeng zhengruifeng deleted the doc_libsvm_data_source branch August 2, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants