[SPARK-28054][SQL][followup] move the bug fix closer to where causes the issue#25234
Closed
cloud-fan wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-28054][SQL][followup] move the bug fix closer to where causes the issue#25234cloud-fan wants to merge 2 commits intoapache:masterfrom
cloud-fan wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Test build #108045 has finished for PR 25234 at commit
|
viirya
reviewed
Jul 23, 2019
| attr.withName(attr.name.toLowerCase) | ||
| } | ||
| // scalastyle:on caselocale | ||
|
|
Member
There was a problem hiding this comment.
This move looks good. And we should use partitionAttributes below.
viirya
approved these changes
Jul 23, 2019
| // with lower cased names. Hive will validate the column names in the partition directories | ||
| // during `loadDynamicPartitions`. Spark needs to write partition directories with lower-cased | ||
| // column names in order to make `loadDynamicPartitions` work. | ||
| attr.withName(name.toLowerCase(Locale.ROOT)) |
Member
There was a problem hiding this comment.
This move looks nicer and also cleaner due to the removal of scalastyle:off caselocale.
|
Test build #108058 has finished for PR 25234 at commit
|
dongjoon-hyun
approved these changes
Jul 23, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to the master.
Member
|
Thank you, @cloud-fan and @viirya ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The bug fixed by #24886 is caused by Hive's
loadDynamicPartitions. It's better to keep the fix surgical and put it right before we callloadDynamicPartitions.This also makes the fix safer, instead of analyzing all the callers of
saveAsHiveFileand proving that they are safe.How was this patch tested?
N/A