[SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval#25225
[SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval#25225wangyum wants to merge 1 commit intoapache:masterfrom wangyum:SPARK-28469
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Please update the title. Changing name is more important than adding simpleString.
|
Test build #107989 has finished for PR 25225 at commit
|
|
retest this please |
|
Thank you for updating. |
|
cc @gatorsmile |
|
Test build #107994 has finished for PR 25225 at commit
|
|
I'm +1 for this changes. |
|
Although PostgreSQL has several variants. In Spark side, we have no such things. So, this will not be misleading. How do you think about this PR, @gatorsmile ? |
|
+1, too. fyi: the cited from https://www.postgresql.org/docs/9.2/datatype.html |
|
Yep. I think it's okay by itself. Thank you for the pointer. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Merged to master. Thank you, @wangyum and @maropu .
cc @gatorsmile and @cloud-fan
|
+1 too |
What changes were proposed in this pull request?
This PR change
CalendarIntervalType's readable string representation fromcalendarintervaltointerval.How was this patch tested?
Existing UT