[SPARK-28416][SQL] Use java.time API in timestampAddInterval #25173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
DateTimeUtils.timestampAddIntervalmethod was rewritten by using Java 8 time API. To add months and microseconds, I used theplusMonths()andplus()methods ofZonedDateTime. Also the signature oftimestampAddInterval()was changed to accept anZoneIdinstance instead ofTimeZone. UsingZoneIdallows to avoid the conversionTimeZone->ZoneIdon every invoke oftimestampAddInterval().How was this patch tested?
By existing test suites
DateExpressionsSuite,TypeCoercionSuiteandCollectionExpressionsSuite.