Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Jul 16, 2019

What changes were proposed in this pull request?

The DateTimeUtils.timestampAddInterval method was rewritten by using Java 8 time API. To add months and microseconds, I used the plusMonths() and plus() methods of ZonedDateTime. Also the signature of timestampAddInterval() was changed to accept an ZoneId instance instead of TimeZone. Using ZoneId allows to avoid the conversion TimeZone -> ZoneId on every invoke of timestampAddInterval().

How was this patch tested?

By existing test suites DateExpressionsSuite, TypeCoercionSuite and CollectionExpressionsSuite.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok pending tests.

@SparkQA
Copy link

SparkQA commented Jul 16, 2019

Test build #107758 has finished for PR 25173 at commit 9eaffa7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 18, 2019

Merged to master

@srowen srowen closed this in 54e058d Jul 18, 2019
@MaxGekk MaxGekk deleted the timestamp-add-interval branch September 18, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants