[SPARK-28404][SS] Fix negative timeout value in RateStreamContinuousPartitionReader #25162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inuousPartitionReader
Contributor
Author
|
cc @srowen @HeartSaVioR it's similar just like this. |
dongjoon-hyun
approved these changes
Jul 15, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. (Pending Jenkins).
Thank you, @gaborgsomogyi !
Member
|
This is found during Flaky Test investigation, but the code fix is inside |
Contributor
Author
|
Thanks @dongjoon-hyun for taking care! Yeah, I've made that step in the PR but not in the jira. |
|
Test build #107688 has finished for PR 25162 at commit
|
Member
|
Merged to master/2.4/2.3. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 15, 2019
…artitionReader ## What changes were proposed in this pull request? `System.currentTimeMillis` read two times in a loop in `RateStreamContinuousPartitionReader`. If the test machine is slow enough and it spends quite some time between the `while` condition check and the `Thread.sleep` then the timeout value is negative and throws `IllegalArgumentException`. In this PR I've fixed this issue. ## How was this patch tested? Existing unit tests. Closes #25162 from gaborgsomogyi/SPARK-28404. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 8f7ccc5) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 15, 2019
…artitionReader ## What changes were proposed in this pull request? `System.currentTimeMillis` read two times in a loop in `RateStreamContinuousPartitionReader`. If the test machine is slow enough and it spends quite some time between the `while` condition check and the `Thread.sleep` then the timeout value is negative and throws `IllegalArgumentException`. In this PR I've fixed this issue. ## How was this patch tested? Existing unit tests. Closes #25162 from gaborgsomogyi/SPARK-28404. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 8f7ccc5) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
|
Late LGTM. Nice catch! |
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
…artitionReader ## What changes were proposed in this pull request? `System.currentTimeMillis` read two times in a loop in `RateStreamContinuousPartitionReader`. If the test machine is slow enough and it spends quite some time between the `while` condition check and the `Thread.sleep` then the timeout value is negative and throws `IllegalArgumentException`. In this PR I've fixed this issue. ## How was this patch tested? Existing unit tests. Closes apache#25162 from gaborgsomogyi/SPARK-28404. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
rluta
pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
…artitionReader ## What changes were proposed in this pull request? `System.currentTimeMillis` read two times in a loop in `RateStreamContinuousPartitionReader`. If the test machine is slow enough and it spends quite some time between the `while` condition check and the `Thread.sleep` then the timeout value is negative and throws `IllegalArgumentException`. In this PR I've fixed this issue. ## How was this patch tested? Existing unit tests. Closes apache#25162 from gaborgsomogyi/SPARK-28404. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 8f7ccc5) Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
…artitionReader ## What changes were proposed in this pull request? `System.currentTimeMillis` read two times in a loop in `RateStreamContinuousPartitionReader`. If the test machine is slow enough and it spends quite some time between the `while` condition check and the `Thread.sleep` then the timeout value is negative and throws `IllegalArgumentException`. In this PR I've fixed this issue. ## How was this patch tested? Existing unit tests. Closes apache#25162 from gaborgsomogyi/SPARK-28404. Authored-by: Gabor Somogyi <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 8f7ccc5) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
System.currentTimeMillisread two times in a loop inRateStreamContinuousPartitionReader. If the test machine is slow enough and it spends quite some time between thewhilecondition check and theThread.sleepthen the timeout value is negative and throwsIllegalArgumentException.In this PR I've fixed this issue.
How was this patch tested?
Existing unit tests.