[SPARK-28370][BUILD][TEST] Upgrade Mockito to 2.28.2 #25139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Member
Author
|
Retest this please |
dongjoon-hyun
changed the title
Member
Author
|
Retest this please. |
dongjoon-hyun
changed the title
|
Test build #107606 has finished for PR 25139 at commit
|
|
Test build #107608 has finished for PR 25139 at commit
|
dongjoon-hyun
changed the title
Member
Author
|
Retest this please. |
|
Test build #107609 has finished for PR 25139 at commit
|
dongjoon-hyun
changed the title
Member
Author
|
|
Test build #107619 has finished for PR 25139 at commit
|
Member
Author
|
Member
Author
|
cc @srowen , @gatorsmile , @dbtsai |
srowen
approved these changes
Jul 13, 2019
Member
Author
|
Thank you, @srowen ! |
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
## What changes were proposed in this pull request? This PR aims to upgrade Mockito from **2.23.4** to **2.28.2** in order to bring the latest bug fixes and to be up-to-date for JDK9+ support before Apache Spark 3.0.0. There is Mockito 3.0 released 4 days ago, but we had better wait and see for the stability. **RELEASE NOTE** https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md **NOTABLE FIXES** - Configure the MethodVisitor for Java 11+ compatibility (2.27.5) - When mock is called multiple times, and verify fails, the error message reports only the first invocation (2.27.4) - Memory leak in mockito-inline calling method on mock with at least a mock as parameter (2.25.0) - Cross-references and a single spy cause memory leak (2.25.0) - Nested spies cause memory leaks (2.25.0) - [Java 9 support] ClassCastExceptions with JDK9 javac (2.24.9, 2.24.3) - Return null instead of causing a CCE (2.24.9, 2.24.3) - Issue with mocking type in "java.util.*", Java 12 (2.24.2) Mainly, Maven (Hadoop-2.7/Hadoop-3.2) and SBT(Hadoop-2.7) Jenkins test passed. ## How was this patch tested? Pass the Jenkins with the exiting UTs. Closes apache#25139 from dongjoon-hyun/SPARK-28370. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
srowen
pushed a commit
that referenced
this pull request
Nov 30, 2019
### What changes were proposed in this pull request? We used 2.28.2 of Mockito as of #25139 because 3.0.0 might be unstable. Now 3.1.0 is released. See release notes - https://github.com/mockito/mockito/blob/v3.1.0/doc/release-notes/official.md ### Why are the changes needed? To bring the fixes made in the dependency. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins will test. Closes #26707 from HyukjinKwon/upgrade-Mockito. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Sean Owen <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
### What changes were proposed in this pull request? We used 2.28.2 of Mockito as of apache#25139 because 3.0.0 might be unstable. Now 3.1.0 is released. See release notes - https://github.com/mockito/mockito/blob/v3.1.0/doc/release-notes/official.md ### Why are the changes needed? To bring the fixes made in the dependency. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Jenkins will test. Closes apache#26707 from HyukjinKwon/upgrade-Mockito. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade Mockito from 2.23.4 to 2.28.2 in order to bring the latest bug fixes and to be up-to-date for JDK9+ support before Apache Spark 3.0.0. There is Mockito 3.0 released 4 days ago, but we had better wait and see for the stability.
RELEASE NOTE
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md
NOTABLE FIXES
Mainly, Maven (Hadoop-2.7/Hadoop-3.2) and SBT(Hadoop-2.7) Jenkins test passed.
How was this patch tested?
Pass the Jenkins with the exiting UTs.