Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jul 11, 2019

What changes were proposed in this pull request?

This PR proposes to replace REL_12_BETA1 to REL_12_BETA2 which is latest.

How was this patch tested?

Manually checked each link and checked via git grep -r REL_12_BETA1 as well.

@HyukjinKwon
Copy link
Member Author

@dongjoon-hyun, seems actually there's no diff to make in Spark SQL files. I was referring this diff postgres/postgres@44e95b5 but that's not in Spark yet ..

@HyukjinKwon
Copy link
Member Author

cc @wangyum too

@dongjoon-hyun
Copy link
Member

Cool! Thank you for confirming. It cleans up my mind. :)

@wangyum
Copy link
Member

wangyum commented Jul 11, 2019

Thank you @HyukjinKwon

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (I checked f90660a).

Now, there is no remaining REL_12_BETA1.
Merged to master (since these are all comments and output files are unchanged.)

@HyukjinKwon
Copy link
Member Author

Thank you guys!

@SparkQA
Copy link

SparkQA commented Jul 11, 2019

Test build #107499 has finished for PR 25105 at commit f90660a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 11, 2019

Test build #107497 has finished for PR 25105 at commit afb2862.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the SPARK-28342 branch March 3, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants