[SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base#25103
Closed
huaxingao wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base#25103huaxingao wants to merge 2 commits intoapache:masterfrom
huaxingao wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #107493 has finished for PR 25103 at commit
|
|
Test build #107801 has finished for PR 25103 at commit
|
Member
|
retest this please |
Member
|
Looks good to me in general if the tests pass |
|
Test build #107816 has finished for PR 25103 at commit
|
Contributor
Author
|
retest this please |
|
Test build #107861 has finished for PR 25103 at commit
|
Member
|
@huaxingao, can you update the diff comparing to the original file? Looks a bit weird. |
Contributor
Author
|
diff updated. @HyukjinKwon |
Member
|
Merged to master. |
Contributor
Author
|
Thanks a lot for your help! @HyukjinKwon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds some tests converted from
outer-join.sqlto test UDFs. Please see contribution guide of this umbrella ticket - SPARK-27921.Diff comparing to 'outer-join.sql'
How was this patch tested?
Tested as guided in SPARK-27921.