Skip to content

Conversation

@carsonwang
Copy link
Contributor

What changes were proposed in this pull request?

The new adaptive execution framework introduced configuration spark.sql.runtime.reoptimization.enabled. We now rename it back to spark.sql.adaptive.enabled as the umbrella configuration for adaptive execution.

How was this patch tested?

Existing tests.

@carsonwang
Copy link
Contributor Author

cc @cloud-fan @maryannxue

@dongjoon-hyun
Copy link
Member

Oh, this is really renaming back, isn't it? @carsonwang ?

@carsonwang
Copy link
Contributor Author

@dongjoon-hyun Yes, we only need one umbrella config for adaptive execution, it can either be spark.sql.runtime.reoptimization.enabled or spark.sql.adaptive.enabled. spark.sql.adaptive.enabled will be better for compatibility. In #24978, I was suggested to rename it in a separated PR.

@SparkQA
Copy link

SparkQA commented Jul 11, 2019

Test build #107486 has finished for PR 25102 at commit fbff48c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 3f375c8 Jul 11, 2019
j-baker pushed a commit to palantir/spark that referenced this pull request Jan 25, 2020
…name

## What changes were proposed in this pull request?
The new adaptive execution framework introduced configuration `spark.sql.runtime.reoptimization.enabled`. We now rename it back to `spark.sql.adaptive.enabled` as the umbrella configuration for adaptive execution.

## How was this patch tested?
Existing tests.

Closes apache#25102 from carsonwang/renameAE.

Authored-by: Carson Wang <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants