-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28275][SQL][PYTHON][TESTS] Convert and port 'count.sql' into UDF test base #25089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @vinodkc, thanks for taking a look for this one. Actually we should add output files too :-). Mind double checking the guide I wrote at SPARK-27921 one by one? |
|
@HyukjinKwon , Thanks for the guidance, I've added output file now. |
|
|
||
| -- count with single expression | ||
| SELECT | ||
| udf(count(*)), udf(count(1)), udf(count(null)), udf(count(a)), udf(count(b)), udf(count(a + b)), udf(count((a, b))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinodkc, can make some other conbinations like udf(count(*)), count(udf(a)), udf(count(udf(a)))?
| udf(count(DISTINCT a)), | ||
| udf(count(DISTINCT b)), | ||
| udf(count(DISTINCT (a + b))), | ||
| udf(count(DISTINCT (a, b))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too :-)
|
Looks fine if there are no output diff comparing to the original file |
|
Test build #107427 has finished for PR 25089 at commit
|
|
Test build #107429 has finished for PR 25089 at commit
|
|
Merged to master. |
What changes were proposed in this pull request?
This PR adds some tests converted from 'count.sql' to test UDFs
Diff comparing to 'count.sql'
How was this patch tested?
Tested as guided in SPARK-27921.