-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28234][CORE][PYTHON] Add python and JavaSparkContext support to get resources #25087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #107413 has finished for PR 25087 at commit
|
|
Test build #107415 has finished for PR 25087 at commit
|
|
retest this please |
|
Test build #107423 has finished for PR 25087 at commit
|
BryanCutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had a couple style comments
|
Yea, looks fine to me in general too. |
|
thanks for the reviews and suggestions, I've updated. |
|
Test build #107459 has finished for PR 25087 at commit
|
|
Test build #107468 has finished for PR 25087 at commit
|
|
Merged to master. |
What changes were proposed in this pull request?
Add python api support and JavaSparkContext support for resources(). I needed the JavaSparkContext support for it to properly translate into python with the py4j stuff.
How was this patch tested?
Unit tests added and manually tested in local cluster mode and on yarn.