Skip to content

Conversation

@tgravescs
Copy link
Contributor

What changes were proposed in this pull request?

Add python api support and JavaSparkContext support for resources(). I needed the JavaSparkContext support for it to properly translate into python with the py4j stuff.

How was this patch tested?

Unit tests added and manually tested in local cluster mode and on yarn.

@SparkQA
Copy link

SparkQA commented Jul 9, 2019

Test build #107413 has finished for PR 25087 at commit 6515601.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28234][PYTHON] Add python and JavaSparkContext support to get resources [SPARK-28234][CORE][PYTHON] Add python and JavaSparkContext support to get resources Jul 9, 2019
@tgravescs
Copy link
Contributor Author

@mengxr @jiangxb1987 @Ngone51

@SparkQA
Copy link

SparkQA commented Jul 9, 2019

Test build #107415 has finished for PR 25087 at commit 7e3f4f9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jul 10, 2019

Test build #107423 has finished for PR 25087 at commit 7e3f4f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a couple style comments

@HyukjinKwon
Copy link
Member

Yea, looks fine to me in general too.

@tgravescs
Copy link
Contributor Author

thanks for the reviews and suggestions, I've updated.

@SparkQA
Copy link

SparkQA commented Jul 10, 2019

Test build #107459 has finished for PR 25087 at commit e6b24d9.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 10, 2019

Test build #107468 has finished for PR 25087 at commit c4c02f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants