Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 8, 2019

What changes were proposed in this pull request?

SslContextFactory is deprecated at Jetty 9.4 and we are using 9.4.18.v20190429. This PR aims to replace it with SslContextFactory.Server.

[WARNING] /Users/dhyun/APACHE/spark/core/src/main/scala/org/apache/spark/SSLOptions.scala:71:
constructor SslContextFactory in class SslContextFactory is deprecated:
see corresponding Javadoc for more information.
[WARNING]       val sslContextFactory = new SslContextFactory()
[WARNING]                               ^

How was this patch tested?

Pass the Jenkins with the existing tests.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28290][CORE][SQL] Use SslContextFactory.Server instead of SslContextFactory [SPARK-28290][CORE][SQL][test-hadoop3.2][test-maven] Use SslContextFactory.Server instead of SslContextFactory Jul 8, 2019
@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Jul 8, 2019

Test build #107316 has finished for PR 25067 at commit 895af34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28290][CORE][SQL][test-hadoop3.2][test-maven] Use SslContextFactory.Server instead of SslContextFactory [SPARK-28290][CORE][SQL] Use SslContextFactory.Server instead of SslContextFactory Jul 8, 2019
@SparkQA
Copy link

SparkQA commented Jul 8, 2019

Test build #107317 has finished for PR 25067 at commit 895af34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@SparkQA
Copy link

SparkQA commented Jul 10, 2019

Test build #107418 has finished for PR 25067 at commit 895af34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, +1

@dongjoon-hyun
Copy link
Member Author

Thank you so much for review and approval, @tgravescs !

@dongjoon-hyun
Copy link
Member Author

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants