-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-27489][WEBUI] UI updates to show executor resource information #25037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #107131 has finished for PR 25037 at commit
|
|
Hi, @tgravescs . The new column looks a little wide. You may want the following.
|
|
sure, I can look at that, the column only shows up when you actually use extra resources right now so if you don't use GPU it won't be there. |
|
Test build #107358 has finished for PR 25037 at commit
|
| return "Dead" | ||
| } | ||
|
|
||
| function formatResourceCells(resources) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a little crowded from the screenshot. It would be better if we could split this single resource cell into several row cells by resource type. But I guess this may require more changes ? Maybe, add \n after each resource type would be good enough ? Or you're intentionally to do this to occupy less space of the cell(since it brings more unnecessary space for other columns(looks more sparse now) ) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to take up less space. the linked PR adds in checkboxes to show columns so we could break up more if its not on by default, but I think at this point we should start with something small and then enhance later as people figure out what is useful.
|
just a note, I'm waiting for pr 25047 and will update this based on that |
|
closing this and will upmerge and open a new one |
What changes were proposed in this pull request?
We are adding other resource type support to the executors and Spark. We should show the resource information for each executor on the UI Executors page.
How was this patch tested?
Updated and added unit tests, tested in standalone, local-cluster, and yarn modes. Tested with active application and via history server.
Attached screenshot of gpu and fpga with lots of them.