-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28136][SQL][TEST] Port int8.sql #24933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #106766 has finished for PR 24933 at commit
|
|
Test build #107392 has finished for PR 24933 at commit
|
|
retest this please |
|
Test build #107406 has finished for PR 24933 at commit
|
|
I updated the PR description by replacing SPARK-28024 with SPARK-26218. For the PR, you need to update only two lines mentioning JIRA. For the others, this looks good. In the previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master.
The last commit is only updating comments and I also tested this int8.sql locally.
Thank you, @wangyum and @HyukjinKwon .
|
Test build #107421 has finished for PR 24933 at commit
|
|
Test build #107425 has finished for PR 24933 at commit
|
What changes were proposed in this pull request?
This PR is to port int8.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/int8.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/int8.out
When porting the test cases, found two PostgreSQL specific features that do not exist in Spark SQL:
SPARK-28137: Missing Data Type Formatting Functions
SPARK-28027: Missing some mathematical operators
Also, found three inconsistent behavior:
SPARK-26218: Throw exception on overflow for integers
SPARK-27923: Spark SQL insert bad inputs to NULL
SPARK-28028: Cast numeric to integral type need round
SPARK-2659: HiveQL: Division operator should always perform fractional division, for example:
How was this patch tested?
N/A