Skip to content

Conversation

@maryannxue
Copy link
Contributor

What changes were proposed in this pull request?

Implemented the clone method for TreeNode based on mapChildren.

How was this patch tested?

Added new UT.

@maryannxue
Copy link
Contributor Author

@hvanhovell

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jun 14, 2019

Test build #106529 has finished for PR 24876 at commit 7f1cd35.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

Merging to master. Thanks!

emanuelebardelli pushed a commit to emanuelebardelli/spark that referenced this pull request Jun 15, 2019
## What changes were proposed in this pull request?

Implemented the `clone` method for `TreeNode` based on `mapChildren`.

## How was this patch tested?

Added new UT.

Closes apache#24876 from maryannxue/treenode-clone.

Authored-by: maryannxue <[email protected]>
Signed-off-by: herman <[email protected]>
j-baker pushed a commit to palantir/spark that referenced this pull request Jan 25, 2020
Implemented the `clone` method for `TreeNode` based on `mapChildren`.

Added new UT.

Closes apache#24876 from maryannxue/treenode-clone.

Authored-by: maryannxue <[email protected]>
Signed-off-by: herman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants