-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-27945][SQL] Minimal changes to support columnar processing #24795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
40c8199
SPARK-27945: Minimal changes to support columnar processing
revans2 484fb41
Fixed test style issue
revans2 52e31ab
Addressed some initial review comments
revans2 2a3287b
Merge branch 'master' into columnar-basic
revans2 31d7248
removed unneeded change
revans2 a388060
Addressed more review comments and added new test
revans2 2edcdc3
Removed columnar changes to Expression
revans2 ca6bb76
Removed reference counting from ColumnVector
revans2 14547b3
Work around for docs issues
revans2 6c0a8ff
Some more fixes for scaladocs in test
revans2 5815658
Addressed review comments
revans2 40b355e
Merge branch 'master' into columnar-basic
revans2 6dfc200
Addressed review comments
revans2 6503059
Addressed more review comments
revans2 4c9ad0c
Updated test to verify that rules replaced expected plan elements
revans2 3b30b06
Some code cleanup and better support for nullability in row to column…
revans2 4c01b74
Bug fix for unsafe projection
revans2 dc53e83
Addressed review comments
revans2 8443b29
Addressed review comments
revans2 7f1753d
Addressed review comments
revans2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
appendNullitself has an assertion that you are not appending a struct. So any call toappendStructwithisNulltrue would have failed.