-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-27945][SQL] Minimal changes to support columnar processing #24795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
40c8199
484fb41
52e31ab
2a3287b
31d7248
a388060
2edcdc3
ca6bb76
14547b3
6c0a8ff
5815658
40b355e
6dfc200
6503059
4c9ad0c
3b30b06
4c01b74
dc53e83
8443b29
7f1753d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,7 @@ public void reset() { | |
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| protected void doClose() { | ||
| if (childColumns != null) { | ||
| for (int i = 0; i < childColumns.length; i++) { | ||
| childColumns[i].close(); | ||
|
|
@@ -604,7 +604,10 @@ public final int appendArray(int length) { | |
| */ | ||
| public final int appendStruct(boolean isNull) { | ||
| if (isNull) { | ||
| appendNull(); | ||
| // This is the same as appendNull but without the assertion for struct types | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this necessary?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because |
||
| reserve(elementsAppended + 1); | ||
| putNull(elementsAppended); | ||
| elementsAppended++; | ||
| for (WritableColumnVector c: childColumns) { | ||
| if (c.type instanceof StructType) { | ||
| c.appendStruct(true); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use more self-declarative name? This is because
columnVectoris public API for developers who want to support their storage.