Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented May 28, 2019

What changes were proposed in this pull request?

This pr moves sql/hive-thriftserver/v2.3.4 to sql/hive-thriftserver/v2.3.5 based on (comment).

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented May 28, 2019

Test build #105866 has finished for PR 24728 at commit 96544b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27737][FOLLOW-UP][SQL] Move sql/hive-thriftserver/v2.3.4 to sql/hive-thriftserver/v2.3.5 [SPARK-27737][FOLLOW-UP][SQL][test-hadoop3.2][test-maven] Move sql/hive-thriftserver/v2.3.4 to sql/hive-thriftserver/v2.3.5 May 28, 2019
@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented May 28, 2019

Test build #105873 has finished for PR 24728 at commit 96544b9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-27737][FOLLOW-UP][SQL][test-hadoop3.2][test-maven] Move sql/hive-thriftserver/v2.3.4 to sql/hive-thriftserver/v2.3.5 [SPARK-27737][SQL][FOLLOW-UP] Move sql/hive-thriftserver/v2.3.4 to sql/hive-thriftserver/v2.3.5 May 28, 2019
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

@wangyum wangyum deleted the SPARK-27737-thriftserver branch May 28, 2019 23:50
@juliuszsompolski
Copy link
Contributor

My meaning was to do the upgrade to v2.3.5 in this separated PR, not only copy - to separate code that is just imported from Hive (all the v2.3.5 code) from code that we write to use it.
Now we still ave v2.3.4 code in v2.3.5 folder, and actually upgrading it to v2.3.5 is still in #24628.

@dongjoon-hyun
Copy link
Member

Hi, @juliuszsompolski .
This PR is okay because it's clearly saying move, not upgrading and we are in the middle of huge transition in #24628 . I merged this intentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants