Skip to content

[SPARK-27467][BUILD] Upgrade Maven to 3.6.1 #24481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 3 commits into from
Closed

[SPARK-27467][BUILD] Upgrade Maven to 3.6.1 #24481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47c25a4
[SPARK-27467][BUILD][TEST-MAVEN] Upgrade Maven to 3.6.1
dongjoon-hyun Apr 16, 2019
1eeeb5e
[SPARK-27467][FOLLOW-UP][BUILD] Upgrade Maven to 3.6.1 in AppVeyor an…
wangyum Apr 27, 2019
2ba886f
switch path
dongjoon-hyun May 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/appveyor-install-dependencies.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,14 @@ if (!(Test-Path $tools)) {
# ========================== Maven
Push-Location $tools

$mavenVer = "3.6.0"
$mavenVer = "3.6.1"
Start-FileDownload "https://archive.apache.org/dist/maven/maven-3/$mavenVer/binaries/apache-maven-$mavenVer-bin.zip" "maven.zip"

# extract
Invoke-Expression "7z.exe x maven.zip"

# add maven to environment variables
$env:Path += ";$tools\apache-maven-$mavenVer\bin"
$env:PATH = "$tools\apache-maven-$mavenVer\bin;" + $env:PATH
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the AppVoyer failure.

$env:M2_HOME = "$tools\apache-maven-$mavenVer"
$env:MAVEN_OPTS = "-Xmx2g -XX:ReservedCodeCacheSize=512m"

Expand Down
2 changes: 1 addition & 1 deletion docs/building-spark.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ license: |
## Apache Maven

The Maven-based build is the build of reference for Apache Spark.
Building Spark using Maven requires Maven 3.6.0 and Java 8.
Building Spark using Maven requires Maven 3.6.1 and Java 8.
Copy link
Member

@srowen srowen Apr 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn't actually require 3.6.1 over 3.6.0, but this is fine. I think it does require 3.6.x though.

Copy link
Member

@wangyum wangyum Apr 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will throw exception if it's not 3.6.1:

mvn package -DskipTests=true
...
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-versions) @ spark-parent_2.12 ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion failed with message:
Detected Maven Version: 3.6.0 is not in the allowed range 3.6.1.
...
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce (enforce-versions) on project spark-parent_2.12: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]
[ERROR]
...

Copy link
Member

@HyukjinKwon HyukjinKwon Apr 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea.. so problem is here. I don't know why it makes the build failed in Appveyor

Spark requires Scala 2.12; support for Scala 2.11 was removed in Spark 3.0.0.

### Setting up Maven's Memory Usage
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
<java.version>1.8</java.version>
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<maven.version>3.6.0</maven.version>
<maven.version>3.6.1</maven.version>
<sbt.project.name>spark</sbt.project.name>
<slf4j.version>1.7.16</slf4j.version>
<log4j.version>1.2.17</log4j.version>
Expand Down